[PATCH 0/2 RESEND] Two fixes for sysctl_sched_rr_timeslice

Cyril Hrubis posted 2 patches 2 years, 6 months ago
kernel/sched/rt.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
[PATCH 0/2 RESEND] Two fixes for sysctl_sched_rr_timeslice
Posted by Cyril Hrubis 2 years, 6 months ago
- Fixes rounding error for initial value with CONFIG_HZ_300

- Fixes read from the file after reset to default (by writing val <= 0)

Cyril Hrubis (2):
  sched/rt: Fix sysctl_sched_rr_timeslice intial value
  sched/rt: sysctl_sched_rr_timeslice show default timeslice after reset

 kernel/sched/rt.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

-- 
2.41.0
Re: [PATCH 0/2 RESEND] Two fixes for sysctl_sched_rr_timeslice
Posted by Mel Gorman 2 years, 6 months ago
On Wed, Aug 02, 2023 at 05:19:04PM +0200, Cyril Hrubis wrote:
> - Fixes rounding error for initial value with CONFIG_HZ_300
> 
> - Fixes read from the file after reset to default (by writing val <= 0)
> 

Hi Peter,

Any chance this can be picked up in tip please? It might have helped if
the leader mentioned the main problem covered in patch 1 -- some HZ
values can fail LTP tests due to a simple rounding error at compile
time.

-- 
Mel Gorman
SUSE Labs
Re: [PATCH 0/2 RESEND] Two fixes for sysctl_sched_rr_timeslice
Posted by Peter Zijlstra 2 years, 6 months ago
On Thu, Aug 10, 2023 at 09:30:28AM +0100, Mel Gorman wrote:
> On Wed, Aug 02, 2023 at 05:19:04PM +0200, Cyril Hrubis wrote:
> > - Fixes rounding error for initial value with CONFIG_HZ_300
> > 
> > - Fixes read from the file after reset to default (by writing val <= 0)
> > 
> 
> Hi Peter,
> 
> Any chance this can be picked up in tip please? It might have helped if
> the leader mentioned the main problem covered in patch 1 -- some HZ
> values can fail LTP tests due to a simple rounding error at compile
> time.

Yah, sorry, too much crazy atm :/ Got it queued.