gpio: vx855: remove unneeded call to platform_set_drvdata()

[PATCH] gpio: vx855: remove unneeded call to platform_set_drvdata()

Posted by Andrei Coardos 2 years, 1 month ago

This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata() call to access the private data of the driver. Also,
the private data is defined in this driver, so there is no risk of it being
accessed outside of this driver file.

Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
---
 drivers/gpio/gpio-vx855.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpio/gpio-vx855.c b/drivers/gpio/gpio-vx855.c
index 69713fd5485b..8fd6c3913d69 100644
--- a/drivers/gpio/gpio-vx855.c
+++ b/drivers/gpio/gpio-vx855.c
@@ -240,8 +240,6 @@ static int vx855gpio_probe(struct platform_device *pdev)
 	if (!vg)
 		return -ENOMEM;
 
-	platform_set_drvdata(pdev, vg);
-
 	dev_info(&pdev->dev, "found VX855 GPIO controller\n");
 	vg->io_gpi = res_gpi->start;
 	vg->io_gpo = res_gpo->start;
-- 
2.34.1

Re: [PATCH] gpio: vx855: remove unneeded call to platform_set_drvdata()

Posted by Bartosz Golaszewski 2 years, 1 month ago

On Tue, Aug 1, 2023 at 10:45 PM Andrei Coardos <aboutphysycs@gmail.com> wrote:
>
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
>
> Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
> Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
> ---
>  drivers/gpio/gpio-vx855.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-vx855.c b/drivers/gpio/gpio-vx855.c
> index 69713fd5485b..8fd6c3913d69 100644
> --- a/drivers/gpio/gpio-vx855.c
> +++ b/drivers/gpio/gpio-vx855.c
> @@ -240,8 +240,6 @@ static int vx855gpio_probe(struct platform_device *pdev)
>         if (!vg)
>                 return -ENOMEM;
>
> -       platform_set_drvdata(pdev, vg);
> -
>         dev_info(&pdev->dev, "found VX855 GPIO controller\n");
>         vg->io_gpi = res_gpi->start;
>         vg->io_gpo = res_gpo->start;
> --
> 2.34.1
>

Applied, thanks!

Bart

Re: [PATCH] gpio: vx855: remove unneeded call to platform_set_drvdata()

Posted by Andy Shevchenko 2 years, 1 month ago

On Tue, Aug 01, 2023 at 11:44:45PM +0300, Andrei Coardos wrote:
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.

Reviewed-by: Andy Shevchenko <andy@kernel.org>

-- 
With Best Regards,
Andy Shevchenko