drm/amdgpu: Clean up errors in vega20_baco.c

[PATCH] drm/amdgpu: Clean up errors in vega20_baco.c

Posted by Ran Sun 2 years, 6 months ago

Fix the following errors reported by checkpatch:

ERROR: that open brace { should be on the previous line
ERROR: space required before the open parenthesis '('

Signed-off-by: Ran Sun <sunran001@208suo.com>
---
 drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_baco.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_baco.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_baco.c
index 8d99c7a5abf8..994c0d374bfa 100644
--- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_baco.c
+++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_baco.c
@@ -31,8 +31,7 @@
 
 #include "amdgpu_ras.h"
 
-static const struct soc15_baco_cmd_entry clean_baco_tbl[] =
-{
+static const struct soc15_baco_cmd_entry clean_baco_tbl[] = {
 	{CMD_WRITE, SOC15_REG_ENTRY(NBIF, 0, mmBIOS_SCRATCH_6), 0, 0, 0, 0},
 	{CMD_WRITE, SOC15_REG_ENTRY(NBIF, 0, mmBIOS_SCRATCH_7), 0, 0, 0, 0},
 };
@@ -90,11 +89,11 @@ int vega20_baco_set_state(struct pp_hwmgr *hwmgr, enum BACO_STATE state)
 			data |= 0x80000000;
 			WREG32_SOC15(THM, 0, mmTHM_BACO_CNTL, data);
 
-			if(smum_send_msg_to_smc_with_parameter(hwmgr,
+			if (smum_send_msg_to_smc_with_parameter(hwmgr,
 					PPSMC_MSG_EnterBaco, 0, NULL))
 				return -EINVAL;
 		} else {
-			if(smum_send_msg_to_smc_with_parameter(hwmgr,
+			if (smum_send_msg_to_smc_with_parameter(hwmgr,
 					PPSMC_MSG_EnterBaco, 1, NULL))
 				return -EINVAL;
 		}
-- 
2.17.1

RE: [PATCH] drm/amdgpu: Clean up errors in vega20_baco.c

Posted by Quan, Evan 2 years, 6 months ago

[AMD Official Use Only - General]

Reviewed-by: Evan Quan <evan.quan@amd.com>

> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Ran
> Sun
> Sent: Tuesday, August 1, 2023 4:03 PM
> To: Deucher, Alexander <Alexander.Deucher@amd.com>; airlied@gmail.com;
> daniel@ffwll.ch
> Cc: Ran Sun <sunran001@208suo.com>; dri-devel@lists.freedesktop.org;
> amd-gfx@lists.freedesktop.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] drm/amdgpu: Clean up errors in vega20_baco.c
>
> Fix the following errors reported by checkpatch:
>
> ERROR: that open brace { should be on the previous line
> ERROR: space required before the open parenthesis '('
>
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
>  drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_baco.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_baco.c
> b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_baco.c
> index 8d99c7a5abf8..994c0d374bfa 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_baco.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_baco.c
> @@ -31,8 +31,7 @@
>
>  #include "amdgpu_ras.h"
>
> -static const struct soc15_baco_cmd_entry clean_baco_tbl[] = -{
> +static const struct soc15_baco_cmd_entry clean_baco_tbl[] = {
>       {CMD_WRITE, SOC15_REG_ENTRY(NBIF, 0, mmBIOS_SCRATCH_6), 0,
> 0, 0, 0},
>       {CMD_WRITE, SOC15_REG_ENTRY(NBIF, 0, mmBIOS_SCRATCH_7), 0,
> 0, 0, 0},  }; @@ -90,11 +89,11 @@ int vega20_baco_set_state(struct
> pp_hwmgr *hwmgr, enum BACO_STATE state)
>                       data |= 0x80000000;
>                       WREG32_SOC15(THM, 0, mmTHM_BACO_CNTL,
> data);
>
> -                     if(smum_send_msg_to_smc_with_parameter(hwmgr,
> +                     if
> (smum_send_msg_to_smc_with_parameter(hwmgr,
>                                       PPSMC_MSG_EnterBaco, 0, NULL))
>                               return -EINVAL;
>               } else {
> -                     if(smum_send_msg_to_smc_with_parameter(hwmgr,
> +                     if
> (smum_send_msg_to_smc_with_parameter(hwmgr,
>                                       PPSMC_MSG_EnterBaco, 1, NULL))
>                               return -EINVAL;
>               }
> --
> 2.17.1

Re: [PATCH] drm/amdgpu: Clean up errors in vega20_baco.c

Posted by Alex Deucher 2 years, 6 months ago

Applied.  Thanks!

On Tue, Aug 1, 2023 at 5:25 AM Quan, Evan <Evan.Quan@amd.com> wrote:
>
> [AMD Official Use Only - General]
>
> Reviewed-by: Evan Quan <evan.quan@amd.com>
>
> > -----Original Message-----
> > From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Ran
> > Sun
> > Sent: Tuesday, August 1, 2023 4:03 PM
> > To: Deucher, Alexander <Alexander.Deucher@amd.com>; airlied@gmail.com;
> > daniel@ffwll.ch
> > Cc: Ran Sun <sunran001@208suo.com>; dri-devel@lists.freedesktop.org;
> > amd-gfx@lists.freedesktop.org; linux-kernel@vger.kernel.org
> > Subject: [PATCH] drm/amdgpu: Clean up errors in vega20_baco.c
> >
> > Fix the following errors reported by checkpatch:
> >
> > ERROR: that open brace { should be on the previous line
> > ERROR: space required before the open parenthesis '('
> >
> > Signed-off-by: Ran Sun <sunran001@208suo.com>
> > ---
> >  drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_baco.c | 7 +++----
> >  1 file changed, 3 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_baco.c
> > b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_baco.c
> > index 8d99c7a5abf8..994c0d374bfa 100644
> > --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_baco.c
> > +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_baco.c
> > @@ -31,8 +31,7 @@
> >
> >  #include "amdgpu_ras.h"
> >
> > -static const struct soc15_baco_cmd_entry clean_baco_tbl[] = -{
> > +static const struct soc15_baco_cmd_entry clean_baco_tbl[] = {
> >       {CMD_WRITE, SOC15_REG_ENTRY(NBIF, 0, mmBIOS_SCRATCH_6), 0,
> > 0, 0, 0},
> >       {CMD_WRITE, SOC15_REG_ENTRY(NBIF, 0, mmBIOS_SCRATCH_7), 0,
> > 0, 0, 0},  }; @@ -90,11 +89,11 @@ int vega20_baco_set_state(struct
> > pp_hwmgr *hwmgr, enum BACO_STATE state)
> >                       data |= 0x80000000;
> >                       WREG32_SOC15(THM, 0, mmTHM_BACO_CNTL,
> > data);
> >
> > -                     if(smum_send_msg_to_smc_with_parameter(hwmgr,
> > +                     if
> > (smum_send_msg_to_smc_with_parameter(hwmgr,
> >                                       PPSMC_MSG_EnterBaco, 0, NULL))
> >                               return -EINVAL;
> >               } else {
> > -                     if(smum_send_msg_to_smc_with_parameter(hwmgr,
> > +                     if
> > (smum_send_msg_to_smc_with_parameter(hwmgr,
> >                                       PPSMC_MSG_EnterBaco, 1, NULL))
> >                               return -EINVAL;
> >               }
> > --
> > 2.17.1
>