Intel metric fixes and event updates

[PATCH v1 0/4] Intel metric fixes and event updates

Posted by Ian Rogers 2 years, 6 months ago

The metric tma_info_pipeline_retire contains uops_retired.slots with
perf metric events. Patch 1 fixes this event sorting so that
uops_retired.slots isn't made a group leader as that needs to be
topdown.slots.

Patch 2 and 3 update the meteorlake and sapphirerapids events.

Patch 4 addresses an issue with event grouping discussed in:
https://lore.kernel.org/lkml/20230719001836.198363-3-irogers@google.com/
by adding and altering metric constraints. The constraints avoid
groups for metrics where the kernel PMU fails to not open the group
(the trigger for the weak group being removed).

Ian Rogers (4):
  perf parse-events x86: Avoid sorting uops_retired.slots
  perf vendor events intel: Update meteorlake to 1.04
  perf vendor events intel: Update sapphirerapids to 1.15
  perf vendor events intel: Update Icelake+ metric constraints

 tools/perf/arch/x86/util/evlist.c             |   7 +-
 tools/perf/arch/x86/util/evsel.c              |   7 +-
 .../arch/x86/alderlake/adl-metrics.json       |  11 +-
 .../arch/x86/alderlaken/adln-metrics.json     |   2 +
 .../arch/x86/icelake/icl-metrics.json         |  10 +-
 .../arch/x86/icelakex/icx-metrics.json        |  10 +-
 tools/perf/pmu-events/arch/x86/mapfile.csv    |   4 +-
 .../pmu-events/arch/x86/meteorlake/cache.json | 165 ++++++++++++++++++
 .../arch/x86/meteorlake/floating-point.json   |   8 +
 .../arch/x86/meteorlake/frontend.json         |  56 ++++++
 .../arch/x86/meteorlake/memory.json           |  80 +++++++++
 .../pmu-events/arch/x86/meteorlake/other.json |  16 ++
 .../arch/x86/meteorlake/pipeline.json         | 159 +++++++++++++++++
 .../arch/x86/rocketlake/rkl-metrics.json      |  10 +-
 .../arch/x86/sapphirerapids/other.json        |  18 ++
 .../arch/x86/sapphirerapids/spr-metrics.json  |   9 +-
 .../arch/x86/tigerlake/tgl-metrics.json       |  10 +-
 17 files changed, 549 insertions(+), 33 deletions(-)

-- 
2.41.0.585.gd2178a4bd4-goog

Re: [PATCH v1 0/4] Intel metric fixes and event updates

Posted by Liang, Kan 2 years, 6 months ago


On 2023-08-01 1:36 a.m., Ian Rogers wrote:
> The metric tma_info_pipeline_retire contains uops_retired.slots with
> perf metric events. Patch 1 fixes this event sorting so that
> uops_retired.slots isn't made a group leader as that needs to be
> topdown.slots.
> 
> Patch 2 and 3 update the meteorlake and sapphirerapids events.
> 
> Patch 4 addresses an issue with event grouping discussed in:
> https://lore.kernel.org/lkml/20230719001836.198363-3-irogers@google.com/
> by adding and altering metric constraints. The constraints avoid
> groups for metrics where the kernel PMU fails to not open the group
> (the trigger for the weak group being removed).
> 
> Ian Rogers (4):
>   perf parse-events x86: Avoid sorting uops_retired.slots
>   perf vendor events intel: Update meteorlake to 1.04
>   perf vendor events intel: Update sapphirerapids to 1.15
>   perf vendor events intel: Update Icelake+ metric constraints
>

Thanks Ian.

Reviewed-by: Kan Liang <kan.liang@linux.intel.com>

Thanks,
Kan

>  tools/perf/arch/x86/util/evlist.c             |   7 +-
>  tools/perf/arch/x86/util/evsel.c              |   7 +-
>  .../arch/x86/alderlake/adl-metrics.json       |  11 +-
>  .../arch/x86/alderlaken/adln-metrics.json     |   2 +
>  .../arch/x86/icelake/icl-metrics.json         |  10 +-
>  .../arch/x86/icelakex/icx-metrics.json        |  10 +-
>  tools/perf/pmu-events/arch/x86/mapfile.csv    |   4 +-
>  .../pmu-events/arch/x86/meteorlake/cache.json | 165 ++++++++++++++++++
>  .../arch/x86/meteorlake/floating-point.json   |   8 +
>  .../arch/x86/meteorlake/frontend.json         |  56 ++++++
>  .../arch/x86/meteorlake/memory.json           |  80 +++++++++
>  .../pmu-events/arch/x86/meteorlake/other.json |  16 ++
>  .../arch/x86/meteorlake/pipeline.json         | 159 +++++++++++++++++
>  .../arch/x86/rocketlake/rkl-metrics.json      |  10 +-
>  .../arch/x86/sapphirerapids/other.json        |  18 ++
>  .../arch/x86/sapphirerapids/spr-metrics.json  |   9 +-
>  .../arch/x86/tigerlake/tgl-metrics.json       |  10 +-
>  17 files changed, 549 insertions(+), 33 deletions(-)
>

Re: [PATCH v1 0/4] Intel metric fixes and event updates

Posted by Arnaldo Carvalho de Melo 2 years, 6 months ago

Em Tue, Aug 01, 2023 at 01:48:45PM -0400, Liang, Kan escreveu:
> 
> 
> On 2023-08-01 1:36 a.m., Ian Rogers wrote:
> > The metric tma_info_pipeline_retire contains uops_retired.slots with
> > perf metric events. Patch 1 fixes this event sorting so that
> > uops_retired.slots isn't made a group leader as that needs to be
> > topdown.slots.
> > 
> > Patch 2 and 3 update the meteorlake and sapphirerapids events.
> > 
> > Patch 4 addresses an issue with event grouping discussed in:
> > https://lore.kernel.org/lkml/20230719001836.198363-3-irogers@google.com/
> > by adding and altering metric constraints. The constraints avoid
> > groups for metrics where the kernel PMU fails to not open the group
> > (the trigger for the weak group being removed).
> > 
> > Ian Rogers (4):
> >   perf parse-events x86: Avoid sorting uops_retired.slots
> >   perf vendor events intel: Update meteorlake to 1.04
> >   perf vendor events intel: Update sapphirerapids to 1.15
> >   perf vendor events intel: Update Icelake+ metric constraints
> >
> 
> Thanks Ian.
> 
> Reviewed-by: Kan Liang <kan.liang@linux.intel.com>

Thanks, applied.

- Arnaldo