[PATCH] ASoC: codecs: rx-macro: Enable RX path clock to match POST_PMD

Krzysztof Kozlowski posted 1 patch 2 years, 6 months ago
sound/soc/codecs/lpass-rx-macro.c | 6 ++++++
1 file changed, 6 insertions(+)
[PATCH] ASoC: codecs: rx-macro: Enable RX path clock to match POST_PMD
Posted by Krzysztof Kozlowski 2 years, 6 months ago
The driver disables RX path clock in SND_SOC_DAPM_POST_PMD of
rx_macro_enable_interp_clk() and rx_macro_enable_mix_path().  Make the
code symmetrical by enabling the clock in SND_SOC_DAPM_PRE_PMU.  This
also matches downstream Qualcomm driver for Qualcomm SM8550 SoC.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 sound/soc/codecs/lpass-rx-macro.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/sound/soc/codecs/lpass-rx-macro.c b/sound/soc/codecs/lpass-rx-macro.c
index 685ca95ef4a9..a758ef4f575a 100644
--- a/sound/soc/codecs/lpass-rx-macro.c
+++ b/sound/soc/codecs/lpass-rx-macro.c
@@ -2529,6 +2529,9 @@ static int rx_macro_enable_interp_clk(struct snd_soc_component *component,
 						      CDC_RX_PATH_PGA_MUTE_MASK, 0x1);
 			snd_soc_component_write_field(component, dsm_reg,
 						      CDC_RX_RXn_DSM_CLK_EN_MASK, 0x1);
+			snd_soc_component_update_bits(component, main_reg,
+						      CDC_RX_PATH_CLK_EN_MASK,
+						      CDC_RX_PATH_CLK_ENABLE);
 			snd_soc_component_update_bits(component, rx_cfg2_reg,
 					CDC_RX_RXn_HPF_CUT_FREQ_MASK, 0x03);
 			rx_macro_load_compander_coeff(component, rx, interp_idx, event);
@@ -2595,6 +2598,9 @@ static int rx_macro_enable_mix_path(struct snd_soc_dapm_widget *w,
 	switch (event) {
 	case SND_SOC_DAPM_PRE_PMU:
 		rx_macro_enable_interp_clk(component, event, w->shift);
+		snd_soc_component_update_bits(component, mix_reg,
+					      CDC_RX_RXn_MIX_CLK_EN_MASK,
+					      CDC_RX_RXn_MIX_CLK_EN_MASK);
 		break;
 	case SND_SOC_DAPM_POST_PMU:
 		snd_soc_component_write(component, gain_reg,
-- 
2.34.1
Re: [PATCH] ASoC: codecs: rx-macro: Enable RX path clock to match POST_PMD
Posted by Mark Brown 2 years, 6 months ago
On Mon, Jul 31, 2023 at 06:55:22PM +0200, Krzysztof Kozlowski wrote:
> The driver disables RX path clock in SND_SOC_DAPM_POST_PMD of
> rx_macro_enable_interp_clk() and rx_macro_enable_mix_path().  Make the
> code symmetrical by enabling the clock in SND_SOC_DAPM_PRE_PMU.  This
> also matches downstream Qualcomm driver for Qualcomm SM8550 SoC.

Was the clock previously enabled somewhere else?  If not how did this
work?