Fix alignment issue and prepare for rust 1.71

[PATCH 0/3] Fix alignment issue and prepare for rust 1.71

Posted by Boqun Feng 2 years, 6 months ago

Hi Miguel,

I end up with this series:

(background: https://lore.kernel.org/rust-for-linux/CANiq72=pb18B6NOcXF03d0ctOP8kv2dqnUeNyEuSvuDb=vs-0g@mail.gmail.com/) 

Patch #1: introduces the core helper function that help calculate the
correct size for krealloc(), and also use the helper function to fix
`__rust_*` ones, this should be backported to stable kernels hence the
Cc.

Patch #2: use the helper function in KernelAllocator

Patch #3: Bjorn's patch with correct use of the helper function.

I have to add a few more SAFETY comments in these `__rust_*` functions,
which may cause conflict with your 1.71 series.

Since all previous patches get refactored a bit, I dropped all the
Reviewed-bys, appreciate anyone to take a look, thanks!

Regards,
Boqun

Björn Roy Baron (1):
  rust: alloc: Add realloc and alloc_zeroed to the GlobalAlloc impl

Boqun Feng (2):
  rust: allocator: Prevent mis-aligned allocation
  rust: allocator: Use krealloc_aligned() in KernelAllocator::alloc

 rust/bindings/bindings_helper.h |   1 +
 rust/kernel/allocator.rs        | 107 ++++++++++++++++++++++++++------
 2 files changed, 90 insertions(+), 18 deletions(-)

-- 
2.41.0

Re: [PATCH 0/3] Fix alignment issue and prepare for rust 1.71

Posted by Miguel Ojeda 2 years, 6 months ago

On Sun, Jul 30, 2023 at 3:29 AM Boqun Feng <boqun.feng@gmail.com> wrote:
>
> Patch #1: introduces the core helper function that help calculate the
> correct size for krealloc(), and also use the helper function to fix
> `__rust_*` ones, this should be backported to stable kernels hence the
> Cc.
>
> Patch #2: use the helper function in KernelAllocator
>
> Patch #3: Bjorn's patch with correct use of the helper function.

Looks good to me, thanks a lot!

> I have to add a few more SAFETY comments in these `__rust_*` functions,
> which may cause conflict with your 1.71 series.

No worries.

> Since all previous patches get refactored a bit, I dropped all the
> Reviewed-bys, appreciate anyone to take a look, thanks!

Thanks Boqun!

Cheers,
Miguel