xprtrdma: Remove unused function declaration rpcrdma_bc_post_recv()

[PATCH net-next] xprtrdma: Remove unused function declaration rpcrdma_bc_post_recv()

Posted by Yue Haibing 2 years, 6 months ago

rpcrdma_bc_post_recv() is never implemented since introduction in
commit f531a5dbc451 ("xprtrdma: Pre-allocate backward rpc_rqst and send/receive buffers").

Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
 net/sunrpc/xprtrdma/xprt_rdma.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/sunrpc/xprtrdma/xprt_rdma.h b/net/sunrpc/xprtrdma/xprt_rdma.h
index 5e5ff6784ef5..da409450dfc0 100644
--- a/net/sunrpc/xprtrdma/xprt_rdma.h
+++ b/net/sunrpc/xprtrdma/xprt_rdma.h
@@ -593,7 +593,6 @@ void xprt_rdma_cleanup(void);
 int xprt_rdma_bc_setup(struct rpc_xprt *, unsigned int);
 size_t xprt_rdma_bc_maxpayload(struct rpc_xprt *);
 unsigned int xprt_rdma_bc_max_slots(struct rpc_xprt *);
-int rpcrdma_bc_post_recv(struct rpcrdma_xprt *, unsigned int);
 void rpcrdma_bc_receive_call(struct rpcrdma_xprt *, struct rpcrdma_rep *);
 int xprt_rdma_bc_send_reply(struct rpc_rqst *rqst);
 void xprt_rdma_bc_free_rqst(struct rpc_rqst *);
-- 
2.34.1

Re: [PATCH net-next] xprtrdma: Remove unused function declaration rpcrdma_bc_post_recv()

Posted by Chuck Lever 2 years, 6 months ago

On Sat, Jul 29, 2023 at 08:31:52PM +0800, Yue Haibing wrote:
> rpcrdma_bc_post_recv() is never implemented since introduction in
> commit f531a5dbc451 ("xprtrdma: Pre-allocate backward rpc_rqst and send/receive buffers").
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>

Reviewed-by: Chuck Lever <chuck.lever@oracle.com>

Anna, can you take this one?


> ---
>  net/sunrpc/xprtrdma/xprt_rdma.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/net/sunrpc/xprtrdma/xprt_rdma.h b/net/sunrpc/xprtrdma/xprt_rdma.h
> index 5e5ff6784ef5..da409450dfc0 100644
> --- a/net/sunrpc/xprtrdma/xprt_rdma.h
> +++ b/net/sunrpc/xprtrdma/xprt_rdma.h
> @@ -593,7 +593,6 @@ void xprt_rdma_cleanup(void);
>  int xprt_rdma_bc_setup(struct rpc_xprt *, unsigned int);
>  size_t xprt_rdma_bc_maxpayload(struct rpc_xprt *);
>  unsigned int xprt_rdma_bc_max_slots(struct rpc_xprt *);
> -int rpcrdma_bc_post_recv(struct rpcrdma_xprt *, unsigned int);
>  void rpcrdma_bc_receive_call(struct rpcrdma_xprt *, struct rpcrdma_rep *);
>  int xprt_rdma_bc_send_reply(struct rpc_rqst *rqst);
>  void xprt_rdma_bc_free_rqst(struct rpc_rqst *);
> -- 
> 2.34.1
> 

-- 
Chuck Lever

Re: [PATCH net-next] xprtrdma: Remove unused function declaration rpcrdma_bc_post_recv()

Posted by Anna Schumaker 2 years, 6 months ago

On Sun, Jul 30, 2023 at 12:01 PM Chuck Lever <chuck.lever@oracle.com> wrote:
>
> On Sat, Jul 29, 2023 at 08:31:52PM +0800, Yue Haibing wrote:
> > rpcrdma_bc_post_recv() is never implemented since introduction in
> > commit f531a5dbc451 ("xprtrdma: Pre-allocate backward rpc_rqst and send/receive buffers").
> >
> > Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
>
> Reviewed-by: Chuck Lever <chuck.lever@oracle.com>
>
> Anna, can you take this one?

Yep! Applying it now so it doesn't get lost!

Anna

>
>
> > ---
> >  net/sunrpc/xprtrdma/xprt_rdma.h | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/net/sunrpc/xprtrdma/xprt_rdma.h b/net/sunrpc/xprtrdma/xprt_rdma.h
> > index 5e5ff6784ef5..da409450dfc0 100644
> > --- a/net/sunrpc/xprtrdma/xprt_rdma.h
> > +++ b/net/sunrpc/xprtrdma/xprt_rdma.h
> > @@ -593,7 +593,6 @@ void xprt_rdma_cleanup(void);
> >  int xprt_rdma_bc_setup(struct rpc_xprt *, unsigned int);
> >  size_t xprt_rdma_bc_maxpayload(struct rpc_xprt *);
> >  unsigned int xprt_rdma_bc_max_slots(struct rpc_xprt *);
> > -int rpcrdma_bc_post_recv(struct rpcrdma_xprt *, unsigned int);
> >  void rpcrdma_bc_receive_call(struct rpcrdma_xprt *, struct rpcrdma_rep *);
> >  int xprt_rdma_bc_send_reply(struct rpc_rqst *rqst);
> >  void xprt_rdma_bc_free_rqst(struct rpc_rqst *);
> > --
> > 2.34.1
> >
>
> --
> Chuck Lever