dt-bindings: leds: rohm,bd71828: Drop select:false

[PATCH] dt-bindings: leds: rohm,bd71828: Drop select:false

Posted by Krzysztof Kozlowski 2 years, 6 months ago

select:false makes the schema basically ignored (not selected for given
compatible), unless some other binding references it.  It's not really
useful nor needed for device bindings, even if they are part of other
binding (like MFD).

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/leds/rohm,bd71828-leds.yaml | 2 --
 1 file changed, 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/leds/rohm,bd71828-leds.yaml b/Documentation/devicetree/bindings/leds/rohm,bd71828-leds.yaml
index 58f0d94c6d71..b7a3ef76cbf4 100644
--- a/Documentation/devicetree/bindings/leds/rohm,bd71828-leds.yaml
+++ b/Documentation/devicetree/bindings/leds/rohm,bd71828-leds.yaml
@@ -18,8 +18,6 @@ description: |
 
   The device has two LED outputs referred as GRNLED and AMBLED in data-sheet.
 
-select: false
-
 properties:
   compatible:
     const: rohm,bd71828-leds
-- 
2.34.1

Re: (subset) [PATCH] dt-bindings: leds: rohm,bd71828: Drop select:false

Posted by Lee Jones 2 years, 5 months ago

On Fri, 28 Jul 2023 19:11:23 +0200, Krzysztof Kozlowski wrote:
> select:false makes the schema basically ignored (not selected for given
> compatible), unless some other binding references it.  It's not really
> useful nor needed for device bindings, even if they are part of other
> binding (like MFD).
> 
> 

Applied, thanks!

[1/1] dt-bindings: leds: rohm,bd71828: Drop select:false
      commit: f044ae6b5a215df5420705dbaa287c59d8d5ef6b

--
Lee Jones [李琼斯]

Re: [PATCH] dt-bindings: leds: rohm,bd71828: Drop select:false

Posted by Matti Vaittinen 2 years, 6 months ago

On 7/28/23 20:11, Krzysztof Kozlowski wrote:
> select:false makes the schema basically ignored (not selected for given
> compatible), unless some other binding references it.  It's not really
> useful nor needed for device bindings, even if they are part of other
> binding (like MFD).
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Matti Vaittinen <mazziesaccount@gmail.com>

Yours,
	Matti

-- 
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~

Re: [PATCH] dt-bindings: leds: rohm,bd71828: Drop select:false

Posted by Conor Dooley 2 years, 6 months ago

On Fri, Jul 28, 2023 at 07:11:23PM +0200, Krzysztof Kozlowski wrote:
> select:false makes the schema basically ignored (not selected for given
> compatible), unless some other binding references it.  It's not really
> useful nor needed for device bindings, even if they are part of other
> binding (like MFD).
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.