MAINTAINERS: add documentation to PSI section

[PATCH] MAINTAINERS: add documentation to PSI section

Posted by Ramazan Safiullin 2 years, 6 months ago

While creating a patch for the psi documentation I noticed that
MAINTENERS was missing an entry in psi.

Add entry for psi documentation.

Signed-off-by: Ramazan Safiullin <ram.safiullin2001@gmail.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index a5c16bb92fe2..2da6643b9488 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -17103,6 +17103,7 @@ PRESSURE STALL INFORMATION (PSI)
 M:	Johannes Weiner <hannes@cmpxchg.org>
 M:	Suren Baghdasaryan <surenb@google.com>
 S:	Maintained
+F:	Documentation/accounting/psi.rst
 F:	include/linux/psi*
 F:	kernel/sched/psi.c
 
-- 
2.25.1

Re: [PATCH] MAINTAINERS: add documentation to PSI section

Posted by Suren Baghdasaryan 2 years, 6 months ago

On Fri, Jul 28, 2023 at 5:09 AM Ramazan Safiullin
<ram.safiullin2001@gmail.com> wrote:
>
> While creating a patch for the psi documentation I noticed that
> MAINTENERS was missing an entry in psi.
>
> Add entry for psi documentation.
>
> Signed-off-by: Ramazan Safiullin <ram.safiullin2001@gmail.com>

Acked-by: Suren Baghdasaryan <surenb@google.com>

> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index a5c16bb92fe2..2da6643b9488 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -17103,6 +17103,7 @@ PRESSURE STALL INFORMATION (PSI)
>  M:     Johannes Weiner <hannes@cmpxchg.org>
>  M:     Suren Baghdasaryan <surenb@google.com>
>  S:     Maintained
> +F:     Documentation/accounting/psi.rst
>  F:     include/linux/psi*
>  F:     kernel/sched/psi.c
>
> --
> 2.25.1
>

Re: [PATCH] MAINTAINERS: add documentation to PSI section

Posted by Suren Baghdasaryan 2 years, 6 months ago

On Mon, Jul 31, 2023 at 4:10 PM Suren Baghdasaryan <surenb@google.com> wrote:
>
> On Fri, Jul 28, 2023 at 5:09 AM Ramazan Safiullin
> <ram.safiullin2001@gmail.com> wrote:
> >
> > While creating a patch for the psi documentation I noticed that
> > MAINTENERS was missing an entry in psi.
> >
> > Add entry for psi documentation.
> >
> > Signed-off-by: Ramazan Safiullin <ram.safiullin2001@gmail.com>
>
> Acked-by: Suren Baghdasaryan <surenb@google.com>

CC'ing Peter to pick up into his tree.

>
> > ---
> >  MAINTAINERS | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index a5c16bb92fe2..2da6643b9488 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -17103,6 +17103,7 @@ PRESSURE STALL INFORMATION (PSI)
> >  M:     Johannes Weiner <hannes@cmpxchg.org>
> >  M:     Suren Baghdasaryan <surenb@google.com>
> >  S:     Maintained
> > +F:     Documentation/accounting/psi.rst
> >  F:     include/linux/psi*
> >  F:     kernel/sched/psi.c
> >
> > --
> > 2.25.1
> >

Re: [PATCH] MAINTAINERS: add documentation to PSI section

Posted by Peter Zijlstra 2 years, 6 months ago

On Mon, Jul 31, 2023 at 04:12:00PM -0700, Suren Baghdasaryan wrote:
> On Mon, Jul 31, 2023 at 4:10 PM Suren Baghdasaryan <surenb@google.com> wrote:
> >
> > On Fri, Jul 28, 2023 at 5:09 AM Ramazan Safiullin
> > <ram.safiullin2001@gmail.com> wrote:
> > >
> > > While creating a patch for the psi documentation I noticed that
> > > MAINTENERS was missing an entry in psi.
> > >
> > > Add entry for psi documentation.
> > >
> > > Signed-off-by: Ramazan Safiullin <ram.safiullin2001@gmail.com>
> >
> > Acked-by: Suren Baghdasaryan <surenb@google.com>
> 
> CC'ing Peter to pick up into his tree.

Well, I'd need the actual patch email, otherwise I can't apply. Either
bounce the thread or have it be resent.

> >
> > > ---
> > >  MAINTAINERS | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index a5c16bb92fe2..2da6643b9488 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -17103,6 +17103,7 @@ PRESSURE STALL INFORMATION (PSI)
> > >  M:     Johannes Weiner <hannes@cmpxchg.org>
> > >  M:     Suren Baghdasaryan <surenb@google.com>
> > >  S:     Maintained
> > > +F:     Documentation/accounting/psi.rst
> > >  F:     include/linux/psi*
> > >  F:     kernel/sched/psi.c
> > >
> > > --
> > > 2.25.1
> > >

Re: [PATCH] MAINTAINERS: add documentation to PSI section

Posted by Lukas Bulwahn 2 years, 6 months ago

On Tue, Aug 1, 2023 at 12:39 PM Peter Zijlstra <peterz@infradead.org> wrote:
>
> On Mon, Jul 31, 2023 at 04:12:00PM -0700, Suren Baghdasaryan wrote:
> > On Mon, Jul 31, 2023 at 4:10 PM Suren Baghdasaryan <surenb@google.com> wrote:
> > >
> > > On Fri, Jul 28, 2023 at 5:09 AM Ramazan Safiullin
> > > <ram.safiullin2001@gmail.com> wrote:
> > > >
> > > > While creating a patch for the psi documentation I noticed that
> > > > MAINTENERS was missing an entry in psi.
> > > >
> > > > Add entry for psi documentation.
> > > >
> > > > Signed-off-by: Ramazan Safiullin <ram.safiullin2001@gmail.com>
> > >
> > > Acked-by: Suren Baghdasaryan <surenb@google.com>
> >
> > CC'ing Peter to pick up into his tree.
>
> Well, I'd need the actual patch email, otherwise I can't apply. Either
> bounce the thread or have it be resent.
>

Speaking on behalf of Ramazan, who I am working with:

Suren, Peter, should we actually better just add you, Peter, as a
reviewer to PSI in MAINTAINERS, so that you get all the patches to psi
stuff in your mailbox and you just need to wait for an Ack from Suren
or Johannes?

Then, we could fix this up in the PSI section and just send out a v2
with the current Ack from Suren and Peter in CC.

And we will fix the typo in the commit message above:
s/MAINTENERS/MAINTAINERS/

Lukas

Re: [PATCH] MAINTAINERS: add documentation to PSI section

Posted by Peter Zijlstra 2 years, 6 months ago

On Tue, Aug 01, 2023 at 01:07:09PM +0200, Lukas Bulwahn wrote:
> On Tue, Aug 1, 2023 at 12:39 PM Peter Zijlstra <peterz@infradead.org> wrote:
> >
> > On Mon, Jul 31, 2023 at 04:12:00PM -0700, Suren Baghdasaryan wrote:
> > > On Mon, Jul 31, 2023 at 4:10 PM Suren Baghdasaryan <surenb@google.com> wrote:
> > > >
> > > > On Fri, Jul 28, 2023 at 5:09 AM Ramazan Safiullin
> > > > <ram.safiullin2001@gmail.com> wrote:
> > > > >
> > > > > While creating a patch for the psi documentation I noticed that
> > > > > MAINTENERS was missing an entry in psi.
> > > > >
> > > > > Add entry for psi documentation.
> > > > >
> > > > > Signed-off-by: Ramazan Safiullin <ram.safiullin2001@gmail.com>
> > > >
> > > > Acked-by: Suren Baghdasaryan <surenb@google.com>
> > >
> > > CC'ing Peter to pick up into his tree.
> >
> > Well, I'd need the actual patch email, otherwise I can't apply. Either
> > bounce the thread or have it be resent.
> >
> 
> Speaking on behalf of Ramazan, who I am working with:
> 
> Suren, Peter, should we actually better just add you, Peter, as a
> reviewer to PSI in MAINTAINERS, so that you get all the patches to psi
> stuff in your mailbox and you just need to wait for an Ack from Suren
> or Johannes?

Well, mostly psi patches touch kernel/sched/psi.c and then I should get
it anyway (throught the kernel/sched/ glob). But sure, one more copy of
my email address in that file isn't going to hurt..

Re: [PATCH] MAINTAINERS: add documentation to PSI section

Posted by Johannes Weiner 2 years, 6 months ago

On Tue, Aug 01, 2023 at 03:03:01PM +0200, Peter Zijlstra wrote:
> On Tue, Aug 01, 2023 at 01:07:09PM +0200, Lukas Bulwahn wrote:
> > On Tue, Aug 1, 2023 at 12:39 PM Peter Zijlstra <peterz@infradead.org> wrote:
> > >
> > > On Mon, Jul 31, 2023 at 04:12:00PM -0700, Suren Baghdasaryan wrote:
> > > > On Mon, Jul 31, 2023 at 4:10 PM Suren Baghdasaryan <surenb@google.com> wrote:
> > > > >
> > > > > On Fri, Jul 28, 2023 at 5:09 AM Ramazan Safiullin
> > > > > <ram.safiullin2001@gmail.com> wrote:
> > > > > >
> > > > > > While creating a patch for the psi documentation I noticed that
> > > > > > MAINTENERS was missing an entry in psi.
> > > > > >
> > > > > > Add entry for psi documentation.
> > > > > >
> > > > > > Signed-off-by: Ramazan Safiullin <ram.safiullin2001@gmail.com>
> > > > >
> > > > > Acked-by: Suren Baghdasaryan <surenb@google.com>
> > > >
> > > > CC'ing Peter to pick up into his tree.
> > >
> > > Well, I'd need the actual patch email, otherwise I can't apply. Either
> > > bounce the thread or have it be resent.
> > >
> > 
> > Speaking on behalf of Ramazan, who I am working with:
> > 
> > Suren, Peter, should we actually better just add you, Peter, as a
> > reviewer to PSI in MAINTAINERS, so that you get all the patches to psi
> > stuff in your mailbox and you just need to wait for an Ack from Suren
> > or Johannes?
> 
> Well, mostly psi patches touch kernel/sched/psi.c and then I should get
> it anyway (throught the kernel/sched/ glob). But sure, one more copy of
> my email address in that file isn't going to hurt..

From f00cd5986718e7ff435444523305d480b54e34e8 Mon Sep 17 00:00:00 2001
From: Johannes Weiner <hannes@cmpxchg.org>
Date: Tue, 1 Aug 2023 09:18:21 -0400
Subject: [PATCH] MAINTAINERS: add Peter explicitly to the psi section

Peter is kind enough to route the low-volume psi patches through the
scheduler tree, but he is frequently not CC'd on them.

While he is matched through the SCHEDULER maintainers and reviewers on
kern/sched/*, that list is long, and mostly not applicable to psi
code. Thus, patch submitters often just CC the explicit PSI entries.

Add him to that section, to make sure he gets those patches.

Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 3be1bdfe8ecc..b68f3ab368c1 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -17037,6 +17037,7 @@ F:	drivers/net/ppp/pptp.c
 PRESSURE STALL INFORMATION (PSI)
 M:	Johannes Weiner <hannes@cmpxchg.org>
 M:	Suren Baghdasaryan <surenb@google.com>
+R:	Peter Ziljstra <peterz@infradead.org>
 S:	Maintained
 F:	include/linux/psi*
 F:	kernel/sched/psi.c
-- 
2.41.0

Re: [PATCH] MAINTAINERS: add documentation to PSI section

Posted by Peter Zijlstra 2 years, 6 months ago

On Tue, Aug 01, 2023 at 09:32:35AM -0400, Johannes Weiner wrote:
> From f00cd5986718e7ff435444523305d480b54e34e8 Mon Sep 17 00:00:00 2001
> From: Johannes Weiner <hannes@cmpxchg.org>
> Date: Tue, 1 Aug 2023 09:18:21 -0400
> Subject: [PATCH] MAINTAINERS: add Peter explicitly to the psi section
> 
> Peter is kind enough to route the low-volume psi patches through the
> scheduler tree, but he is frequently not CC'd on them.
> 
> While he is matched through the SCHEDULER maintainers and reviewers on
> kern/sched/*, that list is long, and mostly not applicable to psi
> code. Thus, patch submitters often just CC the explicit PSI entries.
> 
> Add him to that section, to make sure he gets those patches.
> 
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>

Thanks!

> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 3be1bdfe8ecc..b68f3ab368c1 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -17037,6 +17037,7 @@ F:	drivers/net/ppp/pptp.c
>  PRESSURE STALL INFORMATION (PSI)
>  M:	Johannes Weiner <hannes@cmpxchg.org>
>  M:	Suren Baghdasaryan <surenb@google.com>
> +R:	Peter Ziljstra <peterz@infradead.org>
>  S:	Maintained
>  F:	include/linux/psi*
>  F:	kernel/sched/psi.c
> -- 
> 2.41.0

[tip: sched/core] MAINTAINERS: Add Peter explicitly to the psi section

Posted by tip-bot2 for Johannes Weiner 2 years, 6 months ago

The following commit has been merged into the sched/core branch of tip:

Commit-ID:     113d0a6b3954b57907d1a6e3209f4174f504e0ae
Gitweb:        https://git.kernel.org/tip/113d0a6b3954b57907d1a6e3209f4174f504e0ae
Author:        Johannes Weiner <hannes@cmpxchg.org>
AuthorDate:    Tue, 01 Aug 2023 09:18:21 -04:00
Committer:     Peter Zijlstra <peterz@infradead.org>
CommitterDate: Wed, 02 Aug 2023 16:19:25 +02:00

MAINTAINERS: Add Peter explicitly to the psi section

Peter is kind enough to route the low-volume psi patches through the
scheduler tree, but he is frequently not CC'd on them.

While he is matched through the SCHEDULER maintainers and reviewers on
kern/sched/*, that list is long, and mostly not applicable to psi
code. Thus, patch submitters often just CC the explicit PSI entries.

Add him to that section, to make sure he gets those patches.

Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20230801133235.GA1766885@cmpxchg.org
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index aee3406..f017dc6 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -17047,6 +17047,7 @@ F:	drivers/net/ppp/pptp.c
 PRESSURE STALL INFORMATION (PSI)
 M:	Johannes Weiner <hannes@cmpxchg.org>
 M:	Suren Baghdasaryan <surenb@google.com>
+R:	Peter Ziljstra <peterz@infradead.org>
 S:	Maintained
 F:	include/linux/psi*
 F:	kernel/sched/psi.c