[PATCH v2 0/4] i2c: thunderx: Marvell thunderx i2c changes

Piyush Malgujar posted 4 patches 2 years, 4 months ago
There is a newer version of this series
drivers/i2c/busses/i2c-octeon-core.c     | 96 ++++++++++++++++++------
drivers/i2c/busses/i2c-octeon-core.h     | 27 +++++++
drivers/i2c/busses/i2c-thunderx-pcidrv.c | 23 ++++--
3 files changed, 115 insertions(+), 31 deletions(-)
[PATCH v2 0/4] i2c: thunderx: Marvell thunderx i2c changes
Posted by Piyush Malgujar 2 years, 4 months ago
The changes are for Marvell OcteonTX2 SOC family:

- Handling clock divisor logic using subsytem ID
- Support for high speed mode
- Handle watchdog timeout
- Added ioclk support

Changes since V1:
- Addressed comments, added defines as required
- Removed unnecessary code
- Added a patch to support ioclk if sclk not present in ACPI table

Piyush Malgujar (1):
  i2c: thunderx: Adding ioclk support

Suneel Garapati (3):
  i2c: thunderx: Clock divisor logic changes
  i2c: thunderx: Add support for High speed mode
  i2c: octeon: Handle watchdog timeout

 drivers/i2c/busses/i2c-octeon-core.c     | 96 ++++++++++++++++++------
 drivers/i2c/busses/i2c-octeon-core.h     | 27 +++++++
 drivers/i2c/busses/i2c-thunderx-pcidrv.c | 23 ++++--
 3 files changed, 115 insertions(+), 31 deletions(-)

-- 
2.17.1
Re: [PATCH v2 0/4] i2c: thunderx: Marvell thunderx i2c changes
Posted by Andi Shyti 2 years, 1 month ago
Hi Piyush,

On Fri, Jul 28, 2023 at 05:00:00AM -0700, Piyush Malgujar wrote:
> The changes are for Marvell OcteonTX2 SOC family:
> 
> - Handling clock divisor logic using subsytem ID
> - Support for high speed mode
> - Handle watchdog timeout
> - Added ioclk support
> 
> Changes since V1:
> - Addressed comments, added defines as required
> - Removed unnecessary code
> - Added a patch to support ioclk if sclk not present in ACPI table
> 
> Piyush Malgujar (1):
>   i2c: thunderx: Adding ioclk support
> 
> Suneel Garapati (3):
>   i2c: thunderx: Clock divisor logic changes
>   i2c: thunderx: Add support for High speed mode
>   i2c: octeon: Handle watchdog timeout
> 
>  drivers/i2c/busses/i2c-octeon-core.c     | 96 ++++++++++++++++++------
>  drivers/i2c/busses/i2c-octeon-core.h     | 27 +++++++
>  drivers/i2c/busses/i2c-thunderx-pcidrv.c | 23 ++++--
>  3 files changed, 115 insertions(+), 31 deletions(-)

I was going through the patches that failed to receive an answer,
is this series still valid? Do you still need a round of review
here?

Andi
Re: [PATCH v2 0/4] i2c: thunderx: Marvell thunderx i2c changes
Posted by Piyush Malgujar 2 years, 1 month ago
On Tue, Oct 24, 2023 at 10:14:40PM +0200, Andi Shyti wrote:
> Hi Piyush,
> 
> On Fri, Jul 28, 2023 at 05:00:00AM -0700, Piyush Malgujar wrote:
> > The changes are for Marvell OcteonTX2 SOC family:
> > 
> > - Handling clock divisor logic using subsytem ID
> > - Support for high speed mode
> > - Handle watchdog timeout
> > - Added ioclk support
> > 
> > Changes since V1:
> > - Addressed comments, added defines as required
> > - Removed unnecessary code
> > - Added a patch to support ioclk if sclk not present in ACPI table
> > 
> > Piyush Malgujar (1):
> >   i2c: thunderx: Adding ioclk support
> > 
> > Suneel Garapati (3):
> >   i2c: thunderx: Clock divisor logic changes
> >   i2c: thunderx: Add support for High speed mode
> >   i2c: octeon: Handle watchdog timeout
> > 
> >  drivers/i2c/busses/i2c-octeon-core.c     | 96 ++++++++++++++++++------
> >  drivers/i2c/busses/i2c-octeon-core.h     | 27 +++++++
> >  drivers/i2c/busses/i2c-thunderx-pcidrv.c | 23 ++++--
> >  3 files changed, 115 insertions(+), 31 deletions(-)
> 
> I was going through the patches that failed to receive an answer,
> is this series still valid? Do you still need a round of review
> here?
> 
> Andi

Hi Andi,

Yes, these patches are still valid. These have been acked by you
and were waiting to get reply from Robert.
Please review the patches.

Thanks,
Piyush
Re: [PATCH v2 0/4] i2c: thunderx: Marvell thunderx i2c changes
Posted by Andi Shyti 1 year, 11 months ago
Hi Piyush,

On Thu, Oct 26, 2023 at 05:54:29AM -0700, Piyush Malgujar wrote:
> On Tue, Oct 24, 2023 at 10:14:40PM +0200, Andi Shyti wrote:
> > Hi Piyush,
> > 
> > On Fri, Jul 28, 2023 at 05:00:00AM -0700, Piyush Malgujar wrote:
> > > The changes are for Marvell OcteonTX2 SOC family:
> > > 
> > > - Handling clock divisor logic using subsytem ID
> > > - Support for high speed mode
> > > - Handle watchdog timeout
> > > - Added ioclk support
> > > 
> > > Changes since V1:
> > > - Addressed comments, added defines as required
> > > - Removed unnecessary code
> > > - Added a patch to support ioclk if sclk not present in ACPI table
> > > 
> > > Piyush Malgujar (1):
> > >   i2c: thunderx: Adding ioclk support
> > > 
> > > Suneel Garapati (3):
> > >   i2c: thunderx: Clock divisor logic changes
> > >   i2c: thunderx: Add support for High speed mode
> > >   i2c: octeon: Handle watchdog timeout
> > > 
> > >  drivers/i2c/busses/i2c-octeon-core.c     | 96 ++++++++++++++++++------
> > >  drivers/i2c/busses/i2c-octeon-core.h     | 27 +++++++
> > >  drivers/i2c/busses/i2c-thunderx-pcidrv.c | 23 ++++--
> > >  3 files changed, 115 insertions(+), 31 deletions(-)
> > 
> > I was going through the patches that failed to receive an answer,
> > is this series still valid? Do you still need a round of review
> > here?
> > 
> > Andi
> 
> Hi Andi,
> 
> Yes, these patches are still valid. These have been acked by you
> and were waiting to get reply from Robert.
> Please review the patches.

sorry for the very late response... I guess we won't receive any
answer from Robert... do you mind respinning the series as this
doesn't apply anymore?

Thanks,
Andi
Re: [PATCH v2 0/4] i2c: thunderx: Marvell thunderx i2c changes
Posted by Robert Richter 1 year, 11 months ago
On 04.01.24 23:06:35, Andi Shyti wrote:
> On Thu, Oct 26, 2023 at 05:54:29AM -0700, Piyush Malgujar wrote:
> > On Tue, Oct 24, 2023 at 10:14:40PM +0200, Andi Shyti wrote:
> > > On Fri, Jul 28, 2023 at 05:00:00AM -0700, Piyush Malgujar wrote:

> > > >  drivers/i2c/busses/i2c-octeon-core.c     | 96 ++++++++++++++++++------
> > > >  drivers/i2c/busses/i2c-octeon-core.h     | 27 +++++++
> > > >  drivers/i2c/busses/i2c-thunderx-pcidrv.c | 23 ++++--
> > > >  3 files changed, 115 insertions(+), 31 deletions(-)
> > > 
> > > I was going through the patches that failed to receive an answer,
> > > is this series still valid? Do you still need a round of review
> > > here?
> > > 
> > > Andi
> > 
> > Hi Andi,
> > 
> > Yes, these patches are still valid. These have been acked by you
> > and were waiting to get reply from Robert.
> > Please review the patches.
> 
> sorry for the very late response... I guess we won't receive any
> answer from Robert... do you mind respinning the series as this
> doesn't apply anymore?

I would prefer if someone from Marvell could take over maintainership
for those ThunderX drivers.

Thanks,

-Robert
Re: [PATCH v2 0/4] i2c: thunderx: Marvell thunderx i2c changes
Posted by Andi Shyti 1 year, 10 months ago
Hi Robert,

On Fri, Jan 05, 2024 at 12:10:14PM +0100, Robert Richter wrote:
> On 04.01.24 23:06:35, Andi Shyti wrote:
> > On Thu, Oct 26, 2023 at 05:54:29AM -0700, Piyush Malgujar wrote:
> > > On Tue, Oct 24, 2023 at 10:14:40PM +0200, Andi Shyti wrote:
> > > > On Fri, Jul 28, 2023 at 05:00:00AM -0700, Piyush Malgujar wrote:
> 
> > > > >  drivers/i2c/busses/i2c-octeon-core.c     | 96 ++++++++++++++++++------
> > > > >  drivers/i2c/busses/i2c-octeon-core.h     | 27 +++++++
> > > > >  drivers/i2c/busses/i2c-thunderx-pcidrv.c | 23 ++++--
> > > > >  3 files changed, 115 insertions(+), 31 deletions(-)
> > > > 
> > > > I was going through the patches that failed to receive an answer,
> > > > is this series still valid? Do you still need a round of review
> > > > here?
> > > > 
> > > > Andi
> > > 
> > > Hi Andi,
> > > 
> > > Yes, these patches are still valid. These have been acked by you
> > > and were waiting to get reply from Robert.
> > > Please review the patches.
> > 
> > sorry for the very late response... I guess we won't receive any
> > answer from Robert... do you mind respinning the series as this
> > doesn't apply anymore?
> 
> I would prefer if someone from Marvell could take over maintainership
> for those ThunderX drivers.

As long as it will be

CAVIUM I2C DRIVER
M:      Robert Richter <rric@kernel.org>
S:      Odd Fixes
W:      http://www.marvell.com
F:      drivers/i2c/busses/i2c-octeon*
F:      drivers/i2c/busses/i2c-thunderx*

people will refer to you about this driver. If you really don't
want to be referred to these patches you can consider removing
the entry or I can do it for you.

Meantime, I can accept candidates from Marvell/Cavium.

Andi
Re: [PATCH v2 0/4] i2c: thunderx: Marvell thunderx i2c changes
Posted by Andi Shyti 2 years, 4 months ago
Hi Robert,

On Fri, Jul 28, 2023 at 05:00:00AM -0700, Piyush Malgujar wrote:
> The changes are for Marvell OcteonTX2 SOC family:
> 
> - Handling clock divisor logic using subsytem ID
> - Support for high speed mode
> - Handle watchdog timeout
> - Added ioclk support
> 
> Changes since V1:
> - Addressed comments, added defines as required
> - Removed unnecessary code
> - Added a patch to support ioclk if sclk not present in ACPI table
> 
> Piyush Malgujar (1):
>   i2c: thunderx: Adding ioclk support
> 
> Suneel Garapati (3):
>   i2c: thunderx: Clock divisor logic changes
>   i2c: thunderx: Add support for High speed mode
>   i2c: octeon: Handle watchdog timeout

any chance you could take a look at this series?

Thanks,
Andi