[net-next PATCH] octeontx2-af: Initialize 'cntr_val' to fix uninitialized symbol error

Suman Ghosh posted 1 patch 2 years, 6 months ago
drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[net-next PATCH] octeontx2-af: Initialize 'cntr_val' to fix uninitialized symbol error
Posted by Suman Ghosh 2 years, 6 months ago
drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c:860
otx2_tc_update_mcam_table_del_req()
error: uninitialized symbol 'cntr_val'.

Fixes: ec87f05402f5 ("octeontx2-af: Install TC filter rules in hardware based on priority")
Signed-off-by: Suman Ghosh <sumang@marvell.com>
---
 drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c
index 1e6fc23eca4f..0915a0121316 100644
--- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c
+++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c
@@ -841,7 +841,7 @@ static int otx2_tc_update_mcam_table_del_req(struct otx2_nic *nic,
 	struct list_head *pos, *n;
 	struct otx2_tc_flow *tmp;
 	int i = 0, index = 0;
-	u16 cntr_val;
+	u16 cntr_val = 0;
 
 	/* Find and delete the entry from the list and re-install
 	 * all the entries from beginning to the index of the
@@ -880,7 +880,7 @@ static int otx2_tc_update_mcam_table_add_req(struct otx2_nic *nic,
 	int mcam_idx = flow_cfg->max_flows - flow_cfg->nr_flows - 1;
 	struct otx2_tc_flow *tmp;
 	int list_idx, i;
-	u16 cntr_val;
+	u16 cntr_val = 0;
 
 	/* Find the index of the entry(list_idx) whose priority
 	 * is greater than the new entry and re-install all
-- 
2.25.1
Re: [net-next PATCH] octeontx2-af: Initialize 'cntr_val' to fix uninitialized symbol error
Posted by patchwork-bot+netdevbpf@kernel.org 2 years, 6 months ago
Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 27 Jul 2023 22:01:01 +0530 you wrote:
> drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c:860
> otx2_tc_update_mcam_table_del_req()
> error: uninitialized symbol 'cntr_val'.
> 
> Fixes: ec87f05402f5 ("octeontx2-af: Install TC filter rules in hardware based on priority")
> Signed-off-by: Suman Ghosh <sumang@marvell.com>
> 
> [...]

Here is the summary with links:
  - [net-next] octeontx2-af: Initialize 'cntr_val' to fix uninitialized symbol error
    https://git.kernel.org/netdev/net-next/c/222a6c42e9ef

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html