[PATCH 4/6] bitmap: replace _reg_op(REG_OP_ISFREE) with find_next_bit()

Yury Norov posted 6 patches 2 years, 6 months ago
There is a newer version of this series
[PATCH 4/6] bitmap: replace _reg_op(REG_OP_ISFREE) with find_next_bit()
Posted by Yury Norov 2 years, 6 months ago
_reg_op(REG_OP_ISFREE) can be trivially replaced with find_next_bit().
Drop it.

Signed-off-by: Yury Norov <yury.norov@gmail.com>
---
 lib/bitmap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/bitmap.c b/lib/bitmap.c
index 9be083ad71bf..e0c3bba79181 100644
--- a/lib/bitmap.c
+++ b/lib/bitmap.c
@@ -1354,7 +1354,7 @@ int bitmap_allocate_region(unsigned long *bitmap, unsigned int pos, int order)
 {
 	unsigned int nbits = pos + BIT(order);
 
-	if (!__reg_op(bitmap, pos, order, REG_OP_ISFREE))
+	if (find_next_bit(bitmap, pos, nbits) < nbits)
 		return -EBUSY;
 	bitmap_set(bitmap, pos, nbits);
 	return 0;
-- 
2.39.2
Re: [PATCH 4/6] bitmap: replace _reg_op(REG_OP_ISFREE) with find_next_bit()
Posted by Andy Shevchenko 2 years, 6 months ago
On Wed, Jul 26, 2023 at 07:02:05PM -0700, Yury Norov wrote:
> _reg_op(REG_OP_ISFREE) can be trivially replaced with find_next_bit().
> Drop it.

The verb here is incorrect, you don't drop it, you replaced it.

Same for the other patches.

-- 
With Best Regards,
Andy Shevchenko