[v2] Bluetooth: Remove unused declaration amp_read_loc_info()

[PATCH v2 -next] Bluetooth: Remove unused declaration amp_read_loc_info()

Posted by Yue Haibing 2 years, 6 months ago

This is introduced in commit 903e45411099 ("Bluetooth: AMP: Use HCI cmd to Read Loc AMP Assoc")
and never be implemented. 

Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
v2: fix SOB and update commit log
---
 net/bluetooth/amp.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/bluetooth/amp.h b/net/bluetooth/amp.h
index 832764dfbfb3..97c87abd129f 100644
--- a/net/bluetooth/amp.h
+++ b/net/bluetooth/amp.h
@@ -28,7 +28,6 @@ struct hci_conn *phylink_add(struct hci_dev *hdev, struct amp_mgr *mgr,
 
 int phylink_gen_key(struct hci_conn *hcon, u8 *data, u8 *len, u8 *type);
 
-void amp_read_loc_info(struct hci_dev *hdev, struct amp_mgr *mgr);
 void amp_read_loc_assoc_frag(struct hci_dev *hdev, u8 phy_handle);
 void amp_read_loc_assoc(struct hci_dev *hdev, struct amp_mgr *mgr);
 void amp_read_loc_assoc_final_data(struct hci_dev *hdev,
-- 
2.34.1

Re: [PATCH v2 -next] Bluetooth: Remove unused declaration amp_read_loc_info()

Posted by Luiz Augusto von Dentz 2 years, 6 months ago

Hi Yue,

On Wed, Jul 26, 2023 at 6:42 PM Yue Haibing <yuehaibing@huawei.com> wrote:
>
> This is introduced in commit 903e45411099 ("Bluetooth: AMP: Use HCI cmd to Read Loc AMP Assoc")
> and never be implemented.

The commit information above shall be added with Fixes: tag so it can
be properly backported, etc.

> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
> v2: fix SOB and update commit log
> ---
>  net/bluetooth/amp.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/net/bluetooth/amp.h b/net/bluetooth/amp.h
> index 832764dfbfb3..97c87abd129f 100644
> --- a/net/bluetooth/amp.h
> +++ b/net/bluetooth/amp.h
> @@ -28,7 +28,6 @@ struct hci_conn *phylink_add(struct hci_dev *hdev, struct amp_mgr *mgr,
>
>  int phylink_gen_key(struct hci_conn *hcon, u8 *data, u8 *len, u8 *type);
>
> -void amp_read_loc_info(struct hci_dev *hdev, struct amp_mgr *mgr);
>  void amp_read_loc_assoc_frag(struct hci_dev *hdev, u8 phy_handle);
>  void amp_read_loc_assoc(struct hci_dev *hdev, struct amp_mgr *mgr);
>  void amp_read_loc_assoc_final_data(struct hci_dev *hdev,
> --
> 2.34.1
>


-- 
Luiz Augusto von Dentz

Re: [PATCH v2 -next] Bluetooth: Remove unused declaration amp_read_loc_info()

Posted by YueHaibing 2 years, 6 months ago

On 2023/7/28 6:21, Luiz Augusto von Dentz wrote:
> Hi Yue,
> 
> On Wed, Jul 26, 2023 at 6:42 PM Yue Haibing <yuehaibing@huawei.com> wrote:
>>
>> This is introduced in commit 903e45411099 ("Bluetooth: AMP: Use HCI cmd to Read Loc AMP Assoc")
>> and never be implemented.
> 
> The commit information above shall be added with Fixes: tag so it can
> be properly backported, etc.

Ok, v3 on the way.
> 
>> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
>> ---
>> v2: fix SOB and update commit log
>> ---
>>  net/bluetooth/amp.h | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/net/bluetooth/amp.h b/net/bluetooth/amp.h
>> index 832764dfbfb3..97c87abd129f 100644
>> --- a/net/bluetooth/amp.h
>> +++ b/net/bluetooth/amp.h
>> @@ -28,7 +28,6 @@ struct hci_conn *phylink_add(struct hci_dev *hdev, struct amp_mgr *mgr,
>>
>>  int phylink_gen_key(struct hci_conn *hcon, u8 *data, u8 *len, u8 *type);
>>
>> -void amp_read_loc_info(struct hci_dev *hdev, struct amp_mgr *mgr);
>>  void amp_read_loc_assoc_frag(struct hci_dev *hdev, u8 phy_handle);
>>  void amp_read_loc_assoc(struct hci_dev *hdev, struct amp_mgr *mgr);
>>  void amp_read_loc_assoc_final_data(struct hci_dev *hdev,
>> --
>> 2.34.1
>>
> 
>