x86/sev: Mark boot_ghcb_page and boot_ghcb static

[PATCH -next] x86/sev: Mark boot_ghcb_page and boot_ghcb static

Posted by Li Zetao 2 years, 1 month ago

This patch fixes the following sprse warning:

arch/x86/boot/compressed/sev.c:28:13: warning:
	symbol boot_ghcb_page was not declared. Should it be static?
arch/x86/boot/compressed/sev.c:29:13: warning:
	symbol boot_ghcb was not declared. Should it be static?

No functional change intended.

Signed-off-by: Li Zetao <lizetao1@huawei.com>
---
 arch/x86/boot/compressed/sev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/boot/compressed/sev.c b/arch/x86/boot/compressed/sev.c
index 09dc8c187b3c..323f6298a6b2 100644
--- a/arch/x86/boot/compressed/sev.c
+++ b/arch/x86/boot/compressed/sev.c
@@ -25,8 +25,8 @@
 #include "error.h"
 #include "../msr.h"
 
-struct ghcb boot_ghcb_page __aligned(PAGE_SIZE);
-struct ghcb *boot_ghcb;
+static struct ghcb boot_ghcb_page __aligned(PAGE_SIZE);
+static struct ghcb *boot_ghcb;
 
 /*
  * Copy a version of this function here - insn-eval.c can't be used in
-- 
2.34.1

Re: [PATCH -next] x86/sev: Mark boot_ghcb_page and boot_ghcb static

Posted by Tom Lendacky 2 years, 1 month ago

On 7/26/23 12:06, Li Zetao wrote:
> This patch fixes the following sprse warning:
> 
> arch/x86/boot/compressed/sev.c:28:13: warning:
> 	symbol boot_ghcb_page was not declared. Should it be static?
> arch/x86/boot/compressed/sev.c:29:13: warning:
> 	symbol boot_ghcb was not declared. Should it be static?
> 
> No functional change intended.
> 
> Signed-off-by: Li Zetao <lizetao1@huawei.com>

Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com>

> ---
>   arch/x86/boot/compressed/sev.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/boot/compressed/sev.c b/arch/x86/boot/compressed/sev.c
> index 09dc8c187b3c..323f6298a6b2 100644
> --- a/arch/x86/boot/compressed/sev.c
> +++ b/arch/x86/boot/compressed/sev.c
> @@ -25,8 +25,8 @@
>   #include "error.h"
>   #include "../msr.h"
>   
> -struct ghcb boot_ghcb_page __aligned(PAGE_SIZE);
> -struct ghcb *boot_ghcb;
> +static struct ghcb boot_ghcb_page __aligned(PAGE_SIZE);
> +static struct ghcb *boot_ghcb;
>   
>   /*
>    * Copy a version of this function here - insn-eval.c can't be used in

Re: [PATCH -next] x86/sev: Mark boot_ghcb_page and boot_ghcb static

Posted by Nikunj A. Dadhania 2 years, 1 month ago

On 7/26/2023 10:36 PM, Li Zetao wrote:
> This patch fixes the following sprse warning:

s/sprse/sparse

> 
> arch/x86/boot/compressed/sev.c:28:13: warning:
> 	symbol boot_ghcb_page was not declared. Should it be static?
> arch/x86/boot/compressed/sev.c:29:13: warning:
> 	symbol boot_ghcb was not declared. Should it be static?
> 
> No functional change intended.
> 
> Signed-off-by: Li Zetao <lizetao1@huawei.com>

With the above nit fixed

Reviewed-by: Nikunj A Dadhania <nikunj@amd.com>

> ---
>  arch/x86/boot/compressed/sev.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/boot/compressed/sev.c b/arch/x86/boot/compressed/sev.c
> index 09dc8c187b3c..323f6298a6b2 100644
> --- a/arch/x86/boot/compressed/sev.c
> +++ b/arch/x86/boot/compressed/sev.c
> @@ -25,8 +25,8 @@
>  #include "error.h"
>  #include "../msr.h"
>  
> -struct ghcb boot_ghcb_page __aligned(PAGE_SIZE);
> -struct ghcb *boot_ghcb;
> +static struct ghcb boot_ghcb_page __aligned(PAGE_SIZE);
> +static struct ghcb *boot_ghcb;
>  
>  /*
>   * Copy a version of this function here - insn-eval.c can't be used in

Regards,
Nikunj