[PATCH -next] samples/hw_breakpoint: mark sample_hbp as static

Chen Jiahao posted 1 patch 2 years, 6 months ago
samples/hw_breakpoint/data_breakpoint.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH -next] samples/hw_breakpoint: mark sample_hbp as static
Posted by Chen Jiahao 2 years, 6 months ago
There is a sparse warning shown as below:

samples/hw_breakpoint/data_breakpoint.c:24:19: warning:
symbol 'sample_hbp' was not declared. Should it be static?

Since 'sample_hbp' is only called within data_breakpoint.c,
mark it as static to fix the warning.

Fixes: 44ee63587dce ("percpu: Add __percpu sparse annotations to hw_breakpoint")
Signed-off-by: Chen Jiahao <chenjiahao16@huawei.com>
---
 samples/hw_breakpoint/data_breakpoint.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/samples/hw_breakpoint/data_breakpoint.c b/samples/hw_breakpoint/data_breakpoint.c
index 9debd128b2ab..2f64b89f14da 100644
--- a/samples/hw_breakpoint/data_breakpoint.c
+++ b/samples/hw_breakpoint/data_breakpoint.c
@@ -21,7 +21,7 @@
 #include <linux/perf_event.h>
 #include <linux/hw_breakpoint.h>
 
-struct perf_event * __percpu *sample_hbp;
+static struct perf_event * __percpu *sample_hbp;
 
 static char ksym_name[KSYM_NAME_LEN] = "jiffies";
 module_param_string(ksym, ksym_name, KSYM_NAME_LEN, S_IRUGO);
-- 
2.34.1
Re: [PATCH -next] samples/hw_breakpoint: mark sample_hbp as static
Posted by Luis Chamberlain 2 years, 6 months ago
On Wed, Jul 26, 2023 at 10:17:59AM +0000, Chen Jiahao wrote:
> There is a sparse warning shown as below:
> 
> samples/hw_breakpoint/data_breakpoint.c:24:19: warning:
> symbol 'sample_hbp' was not declared. Should it be static?
> 
> Since 'sample_hbp' is only called within data_breakpoint.c,
> mark it as static to fix the warning.
> 
> Fixes: 44ee63587dce ("percpu: Add __percpu sparse annotations to hw_breakpoint")
> Signed-off-by: Chen Jiahao <chenjiahao16@huawei.com>

Thanks, applied and pushed.

  Luis