[PATCH] ARM: dts: imx: Set default tuning step for imx6sx usdhc

Xiaolei Wang posted 1 patch 2 years, 1 month ago
arch/arm/boot/dts/nxp/imx/imx6sx.dtsi | 6 ++++++
1 file changed, 6 insertions(+)
[PATCH] ARM: dts: imx: Set default tuning step for imx6sx usdhc
Posted by Xiaolei Wang 2 years, 1 month ago
If the tuning step is not set, the tuning step is set to 1.
For some sd cards, the following Tuning timeout will occur.

Tuning failed, falling back to fixed sampling clock

So set the default tuning step. This refers to the NXP vendor's
commit below:

https://github.com/nxp-imx/linux-imx/blob/lf-6.1.y/
arch/arm/boot/dts/imx6sx.dtsi#L1108-L1109

Fixes: 1e336aa0c025 ("mmc: sdhci-esdhc-imx: correct the tuning start tap and step setting")
Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com>
---
 arch/arm/boot/dts/nxp/imx/imx6sx.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6sx.dtsi b/arch/arm/boot/dts/nxp/imx/imx6sx.dtsi
index 3a4308666552..5bed7b411a3a 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6sx.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6sx.dtsi
@@ -1010,6 +1010,8 @@ usdhc1: mmc@2190000 {
 					 <&clks IMX6SX_CLK_USDHC1>;
 				clock-names = "ipg", "ahb", "per";
 				bus-width = <4>;
+				fsl,tuning-start-tap = <20>;
+				fsl,tuning-step= <2>;
 				status = "disabled";
 			};
 
@@ -1022,6 +1024,8 @@ usdhc2: mmc@2194000 {
 					 <&clks IMX6SX_CLK_USDHC2>;
 				clock-names = "ipg", "ahb", "per";
 				bus-width = <4>;
+				fsl,tuning-start-tap = <20>;
+				fsl,tuning-step= <2>;
 				status = "disabled";
 			};
 
@@ -1034,6 +1038,8 @@ usdhc3: mmc@2198000 {
 					 <&clks IMX6SX_CLK_USDHC3>;
 				clock-names = "ipg", "ahb", "per";
 				bus-width = <4>;
+				fsl,tuning-start-tap = <20>;
+				fsl,tuning-step= <2>;
 				status = "disabled";
 			};
 
-- 
2.25.1
Re: [PATCH] ARM: dts: imx: Set default tuning step for imx6sx usdhc
Posted by Shawn Guo 2 years, 1 month ago
On Wed, Jul 26, 2023 at 03:57:47PM +0800, Xiaolei Wang wrote:
> If the tuning step is not set, the tuning step is set to 1.
> For some sd cards, the following Tuning timeout will occur.
> 
> Tuning failed, falling back to fixed sampling clock
> 
> So set the default tuning step. This refers to the NXP vendor's
> commit below:
> 
> https://github.com/nxp-imx/linux-imx/blob/lf-6.1.y/
> arch/arm/boot/dts/imx6sx.dtsi#L1108-L1109
> 
> Fixes: 1e336aa0c025 ("mmc: sdhci-esdhc-imx: correct the tuning start tap and step setting")
> Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com>

Applied, thanks!
Re: [PATCH] ARM: dts: imx: Set default tuning step for imx6sx usdhc
Posted by Fabio Estevam 2 years, 1 month ago
Hi Xiaolei,

On Wed, Jul 26, 2023 at 4:58 AM Xiaolei Wang <xiaolei.wang@windriver.com> wrote:
>
> If the tuning step is not set, the tuning step is set to 1.
> For some sd cards, the following Tuning timeout will occur.
>
> Tuning failed, falling back to fixed sampling clock
>
> So set the default tuning step. This refers to the NXP vendor's
> commit below:
>
> https://github.com/nxp-imx/linux-imx/blob/lf-6.1.y/
> arch/arm/boot/dts/imx6sx.dtsi#L1108-L1109
>
> Fixes: 1e336aa0c025 ("mmc: sdhci-esdhc-imx: correct the tuning start tap and step setting")
> Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com>

Thanks for your patch:

Reviewed-by: Fabio Estevam <festevam@gmail.com>