[PATCH] arm64: dts: tegra: drop incorrect maxim,disable-etr in Smaug

Krzysztof Kozlowski posted 1 patch 2 years, 6 months ago
arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 1 -
1 file changed, 1 deletion(-)
[PATCH] arm64: dts: tegra: drop incorrect maxim,disable-etr in Smaug
Posted by Krzysztof Kozlowski 2 years, 6 months ago
There is no "maxim,disable-etr" property (but there is
maxim,enable-etr), neither in the bindings nor in the Linux driver:

  tegra210-smaug.dtb: regulator@1c: Unevaluated properties are not allowed ('maxim,disable-etr' was unexpected)

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
index 80476893fa57..53805555dd2d 100644
--- a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
+++ b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
@@ -1395,7 +1395,6 @@ max77621_gpu: regulator@1c {
 			maxim,dvs-default-state = <1>;
 			maxim,enable-active-discharge;
 			maxim,enable-bias-control;
-			maxim,disable-etr;
 			maxim,enable-gpio = <&pmic 6 GPIO_ACTIVE_HIGH>;
 			maxim,externally-enable;
 		};
-- 
2.34.1
Re: [PATCH] arm64: dts: tegra: drop incorrect maxim,disable-etr in Smaug
Posted by Thierry Reding 2 years, 6 months ago
From: Thierry Reding <treding@nvidia.com>


On Tue, 25 Jul 2023 16:26:38 +0200, Krzysztof Kozlowski wrote:
> There is no "maxim,disable-etr" property (but there is
> maxim,enable-etr), neither in the bindings nor in the Linux driver:
> 
>   tegra210-smaug.dtb: regulator@1c: Unevaluated properties are not allowed ('maxim,disable-etr' was unexpected)
> 
> 

Applied, thanks!

[1/1] arm64: dts: tegra: drop incorrect maxim,disable-etr in Smaug
      (no commit info)

Best regards,
-- 
Thierry Reding <treding@nvidia.com>
Re: [PATCH] arm64: dts: tegra: drop incorrect maxim,disable-etr in Smaug
Posted by Diogo Ivo 2 years, 6 months ago
Thank you for catching this one! Just to be sure I tested it
on the Pixel C and everything is (obviously) working, so

Reviewed-by: Diogo Ivo <diogo.ivo@tecnico.ulisboa.pt>