coresight: Fix all W=1 build warnings

[PATCH] coresight: Fix all W=1 build warnings

Posted by James Clark 2 years, 6 months ago

The kernel test robot looks for new warnings in a W=1 build, so fix all
the existing warnings to make it easier to spot new ones when building
locally.

The fixes are for undocumented function arguments and an incorrect doc
style.

Signed-off-by: James Clark <james.clark@arm.com>
---
 drivers/hwtracing/coresight/coresight-cti-core.c  | 2 +-
 drivers/hwtracing/coresight/coresight-etm4x-cfg.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/hwtracing/coresight/coresight-cti-core.c b/drivers/hwtracing/coresight/coresight-cti-core.c
index 7023ff70cc28..3999d0a2cb60 100644
--- a/drivers/hwtracing/coresight/coresight-cti-core.c
+++ b/drivers/hwtracing/coresight/coresight-cti-core.c
@@ -22,7 +22,7 @@
 #include "coresight-priv.h"
 #include "coresight-cti.h"
 
-/**
+/*
  * CTI devices can be associated with a PE, or be connected to CoreSight
  * hardware. We have a list of all CTIs irrespective of CPU bound or
  * otherwise.
diff --git a/drivers/hwtracing/coresight/coresight-etm4x-cfg.c b/drivers/hwtracing/coresight/coresight-etm4x-cfg.c
index d2ea903231b2..c302072b293a 100644
--- a/drivers/hwtracing/coresight/coresight-etm4x-cfg.c
+++ b/drivers/hwtracing/coresight/coresight-etm4x-cfg.c
@@ -40,7 +40,7 @@
  * Invalid offsets will result in fail code return and feature load failure.
  *
  * @drvdata:	driver data to map into.
- * @reg:	register to map.
+ * @reg_csdev:	register to map.
  * @offset:	device offset for the register
  */
 static int etm4_cfg_map_reg_offset(struct etmv4_drvdata *drvdata,
@@ -132,7 +132,7 @@ static int etm4_cfg_map_reg_offset(struct etmv4_drvdata *drvdata,
  * etm4_cfg_load_feature - load a feature into a device instance.
  *
  * @csdev:	An ETMv4 CoreSight device.
- * @feat:	The feature to be loaded.
+ * @feat_csdev:	The feature to be loaded.
  *
  * The function will load a feature instance into the device, checking that
  * the register definitions are valid for the device.
-- 
2.34.1

Re: [PATCH] coresight: Fix all W=1 build warnings

Posted by Suzuki K Poulose 2 years, 6 months ago

On Tue, 25 Jul 2023 15:06:04 +0100, James Clark wrote:
> The kernel test robot looks for new warnings in a W=1 build, so fix all
> the existing warnings to make it easier to spot new ones when building
> locally.
> 
> The fixes are for undocumented function arguments and an incorrect doc
> style.
> 
> [...]

Applied, thanks!

[1/1] coresight: Fix all W=1 build warnings
      https://git.kernel.org/coresight/c/04e8429c5b4f644257fe64db3403205a7a41e33b

Best regards,
-- 
Suzuki K Poulose <suzuki.poulose@arm.com>

Re: [PATCH] coresight: Fix all W=1 build warnings

Posted by Suzuki K Poulose 2 years, 6 months ago

On 26/07/2023 18:06, Suzuki K Poulose wrote:
> On Tue, 25 Jul 2023 15:06:04 +0100, James Clark wrote:
>> The kernel test robot looks for new warnings in a W=1 build, so fix all
>> the existing warnings to make it easier to spot new ones when building
>> locally.
>>
>> The fixes are for undocumented function arguments and an incorrect doc
>> style.
>>
>> [...]
> 
> Applied, thanks!
> 
> [1/1] coresight: Fix all W=1 build warnings
>        https://git.kernel.org/coresight/c/04e8429c5b4f644257fe64db3403205a7a41e33b

Apologies, that should be:

  https://git.kernel.org/coresight/c/04e8429c5b4f

Suzuki

Re: [PATCH] coresight: Fix all W=1 build warnings

Posted by Mike Leach 2 years, 6 months ago

On Tue, 25 Jul 2023 at 15:06, James Clark <james.clark@arm.com> wrote:
>
> The kernel test robot looks for new warnings in a W=1 build, so fix all
> the existing warnings to make it easier to spot new ones when building
> locally.
>
> The fixes are for undocumented function arguments and an incorrect doc
> style.
>
> Signed-off-by: James Clark <james.clark@arm.com>
> ---
>  drivers/hwtracing/coresight/coresight-cti-core.c  | 2 +-
>  drivers/hwtracing/coresight/coresight-etm4x-cfg.c | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-cti-core.c b/drivers/hwtracing/coresight/coresight-cti-core.c
> index 7023ff70cc28..3999d0a2cb60 100644
> --- a/drivers/hwtracing/coresight/coresight-cti-core.c
> +++ b/drivers/hwtracing/coresight/coresight-cti-core.c
> @@ -22,7 +22,7 @@
>  #include "coresight-priv.h"
>  #include "coresight-cti.h"
>
> -/**
> +/*
>   * CTI devices can be associated with a PE, or be connected to CoreSight
>   * hardware. We have a list of all CTIs irrespective of CPU bound or
>   * otherwise.
> diff --git a/drivers/hwtracing/coresight/coresight-etm4x-cfg.c b/drivers/hwtracing/coresight/coresight-etm4x-cfg.c
> index d2ea903231b2..c302072b293a 100644
> --- a/drivers/hwtracing/coresight/coresight-etm4x-cfg.c
> +++ b/drivers/hwtracing/coresight/coresight-etm4x-cfg.c
> @@ -40,7 +40,7 @@
>   * Invalid offsets will result in fail code return and feature load failure.
>   *
>   * @drvdata:   driver data to map into.
> - * @reg:       register to map.
> + * @reg_csdev: register to map.
>   * @offset:    device offset for the register
>   */
>  static int etm4_cfg_map_reg_offset(struct etmv4_drvdata *drvdata,
> @@ -132,7 +132,7 @@ static int etm4_cfg_map_reg_offset(struct etmv4_drvdata *drvdata,
>   * etm4_cfg_load_feature - load a feature into a device instance.
>   *
>   * @csdev:     An ETMv4 CoreSight device.
> - * @feat:      The feature to be loaded.
> + * @feat_csdev:        The feature to be loaded.
>   *
>   * The function will load a feature instance into the device, checking that
>   * the register definitions are valid for the device.
> --
> 2.34.1
>

Reviewed-by: Mike Leach <mike.leach@linaro.org>
-- 
Mike Leach
Principal Engineer, ARM Ltd.
Manchester Design Centre. UK