arm64: dts: qcom: msm8939-samsung-a7: Drop internal pull for SD CD

[PATCH] arm64: dts: qcom: msm8939-samsung-a7: Drop internal pull for SD CD

Posted by Stephan Gerhold 2 years, 6 months ago

A7 seems to have external pull-up for the SD card chip detect (like
most MSM8916/MSM8939 devices) so drop the internal pull-up. It's not
necessary.

Tested-by: "Lin, Meng-Bo" <linmengbo0689@protonmail.com>
Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
---
 arch/arm64/boot/dts/qcom/msm8939-samsung-a7.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8939-samsung-a7.dts b/arch/arm64/boot/dts/qcom/msm8939-samsung-a7.dts
index 66e56ac59998..ba652909d162 100644
--- a/arch/arm64/boot/dts/qcom/msm8939-samsung-a7.dts
+++ b/arch/arm64/boot/dts/qcom/msm8939-samsung-a7.dts
@@ -448,7 +448,7 @@ sdc2_cd_default: sdc2-cd-default-state {
 		pins = "gpio38";
 		function = "gpio";
 		drive-strength = <2>;
-		bias-pull-up;
+		bias-disable;
 	};
 
 	sensor_i2c_default: sensor-i2c-default-state {

---
base-commit: 34e472f41d9cd04400b80649ce82cfe11fbe135a
change-id: 20230723-a7sdc2cdnopull-3eb4cadf8f1f

Best regards,
-- 
Stephan Gerhold <stephan@gerhold.net>

Re: [PATCH] arm64: dts: qcom: msm8939-samsung-a7: Drop internal pull for SD CD

Posted by Bjorn Andersson 2 years, 6 months ago

On Sun, 23 Jul 2023 12:54:41 +0200, Stephan Gerhold wrote:
> A7 seems to have external pull-up for the SD card chip detect (like
> most MSM8916/MSM8939 devices) so drop the internal pull-up. It's not
> necessary.
> 
> 

Applied, thanks!

[1/1] arm64: dts: qcom: msm8939-samsung-a7: Drop internal pull for SD CD
      commit: ee0e92b8e7b5894daf5c94e6433a1989f7233fbe

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

Re: [PATCH] arm64: dts: qcom: msm8939-samsung-a7: Drop internal pull for SD CD

Posted by Konrad Dybcio 2 years, 6 months ago

On 23.07.2023 12:54, Stephan Gerhold wrote:
> A7 seems to have external pull-up for the SD card chip detect (like
> most MSM8916/MSM8939 devices) so drop the internal pull-up. It's not
> necessary.
> 
> Tested-by: "Lin, Meng-Bo" <linmengbo0689@protonmail.com>
> Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
> ---
If you say so..

Acked-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad