[PATCH v2 0/9] KVM: x86/mmu: Clean up MMU_DEBUG and BUG/WARN usage

Sean Christopherson posted 9 patches 2 years, 6 months ago
There is a newer version of this series
arch/x86/kvm/Kconfig            |  13 ++++
arch/x86/kvm/mmu/mmu.c          | 127 ++++++++++++++------------------
arch/x86/kvm/mmu/mmu_internal.h |  12 +--
arch/x86/kvm/mmu/page_track.c   |  16 ++--
arch/x86/kvm/mmu/paging_tmpl.h  |  16 +++-
arch/x86/kvm/mmu/spte.c         |   4 +-
arch/x86/kvm/mmu/spte.h         |   8 +-
arch/x86/kvm/mmu/tdp_iter.c     |   4 +-
arch/x86/kvm/mmu/tdp_mmu.c      |  28 +++----
include/linux/kvm_host.h        |  19 +++++
10 files changed, 134 insertions(+), 113 deletions(-)
[PATCH v2 0/9] KVM: x86/mmu: Clean up MMU_DEBUG and BUG/WARN usage
Posted by Sean Christopherson 2 years, 6 months ago
This series consist of three loosely related miniseries:

 1. Remove the noisy prints buried behind MMU_DEBUG, and replace MMU_DEBUG
    with a KVM_PROVE_MMU Kconfig.

 2. Use WARN_ON_ONCE() for all runtime WARNs, i.e. avoid spamming the
    kernel log if something goes awry in the MMU.

 3. Demote BUG() usage in the shadow MMU to KVM_BUG_ON() when the kernel
    is built with CONFIG_BUG_ON_DATA_CORRUPTION=n.


v2:
 - Collect a review. [Mingwei]
 - Call out the more obvious path to FNAME(walk_addr_generic) in patch 6. [David]
 - Use BUILD_BUG_ON_INVALID() for the stub. [David]

v1: https://lore.kernel.org/all/20230511235917.639770-1-seanjc@google.com

Mingwei Zhang (1):
  KVM: x86/mmu: Plumb "struct kvm" all the way to pte_list_remove()

Sean Christopherson (8):
  KVM: x86/mmu: Delete rmap_printk() and all its usage
  KVM: x86/mmu: Delete the "dbg" module param
  KVM: x86/mmu: Rename MMU_WARN_ON() to KVM_MMU_WARN_ON()
  KVM: x86/mmu: Convert "runtime" WARN_ON() assertions to WARN_ON_ONCE()
  KVM: x86/mmu: Bug the VM if a vCPU ends up in long mode without PAE
    enabled
  KVM: x86/mmu: Replace MMU_DEBUG with proper KVM_PROVE_MMU Kconfig
  KVM: x86/mmu: Use BUILD_BUG_ON_INVALID() for KVM_MMU_WARN_ON() stub
  KVM: x86/mmu: BUG() in rmap helpers iff
    CONFIG_BUG_ON_DATA_CORRUPTION=y

 arch/x86/kvm/Kconfig            |  13 ++++
 arch/x86/kvm/mmu/mmu.c          | 127 ++++++++++++++------------------
 arch/x86/kvm/mmu/mmu_internal.h |  12 +--
 arch/x86/kvm/mmu/page_track.c   |  16 ++--
 arch/x86/kvm/mmu/paging_tmpl.h  |  16 +++-
 arch/x86/kvm/mmu/spte.c         |   4 +-
 arch/x86/kvm/mmu/spte.h         |   8 +-
 arch/x86/kvm/mmu/tdp_iter.c     |   4 +-
 arch/x86/kvm/mmu/tdp_mmu.c      |  28 +++----
 include/linux/kvm_host.h        |  19 +++++
 10 files changed, 134 insertions(+), 113 deletions(-)


base-commit: 294ebdda1560d3eb515da88b805ba7f88eb28d21
-- 
2.41.0.487.g6d72f3e995-goog