gpio :mlxbf2: remove unneeded platform_set_drvdata() call

[PATCH] gpio :mlxbf2: remove unneeded platform_set_drvdata() call

Posted by Andrei Coardos 2 years, 6 months ago

This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata() call to access the private data of the driver.
Also, the private data is defined in this driver, so there is no risk of
it being accessed outside of this driver file.

Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
---
 drivers/gpio/gpio-mlxbf2.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpio/gpio-mlxbf2.c b/drivers/gpio/gpio-mlxbf2.c
index 6abe01bc39c3..cf91b6e74d88 100644
--- a/drivers/gpio/gpio-mlxbf2.c
+++ b/drivers/gpio/gpio-mlxbf2.c
@@ -420,8 +420,6 @@ mlxbf2_gpio_probe(struct platform_device *pdev)
 		}
 	}
 
-	platform_set_drvdata(pdev, gs);
-
 	ret = devm_gpiochip_add_data(dev, &gs->gc, gs);
 	if (ret) {
 		dev_err(dev, "Failed adding memory mapped gpiochip\n");
-- 
2.34.1

Re: [PATCH] gpio :mlxbf2: remove unneeded platform_set_drvdata() call

Posted by Andy Shevchenko 2 years, 6 months ago

On Thu, Jul 20, 2023 at 4:49 PM Andrei Coardos <aboutphysycs@gmail.com> wrote:
>
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver.
> Also, the private data is defined in this driver, so there is no risk of
> it being accessed outside of this driver file.

The Subject is broken.

-- 
With Best Regards,
Andy Shevchenko