[v1] Two minor cleanups for compaction

[PATCH 0/2] Two minor cleanups for compaction

Posted by Kemeng Shi 2 years, 6 months ago

Hi all, this series contains two random cleanups for compaction.
Patch 1 correct wrong comment in fast_isolate_freepages.
Patch 2 avoid to call unneeded pageblock_end_pfn when no_set_skip_hint
is set.
Thanks!

Kemeng Shi (2):
  mm/compaction: correct comment of candidate pfn in
    fast_isolate_freepages
  mm/compaction: avoid unneeded pageblock_end_pfn when no_set_skip_hint
    is set

 mm/compaction.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

-- 
2.30.0

Re: [PATCH 0/2] Two minor cleanups for compaction

Posted by Baolin Wang 2 years, 6 months ago


On 7/20/2023 7:53 PM, Kemeng Shi wrote:
> Hi all, this series contains two random cleanups for compaction.
> Patch 1 correct wrong comment in fast_isolate_freepages.
> Patch 2 avoid to call unneeded pageblock_end_pfn when no_set_skip_hint
> is set.
> Thanks!

I only received the patch 2 in this patch set, and I checked the lore
archives[1], still did not find patch 1. You missed patch 1?

[1] 
https://lore.kernel.org/linux-mm/20230720115351.2039431-1-shikemeng@huaweicloud.com/

> 
> Kemeng Shi (2):
>    mm/compaction: correct comment of candidate pfn in
>      fast_isolate_freepages
>    mm/compaction: avoid unneeded pageblock_end_pfn when no_set_skip_hint
>      is set
> 
>   mm/compaction.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>

Re: [PATCH 0/2] Two minor cleanups for compaction

Posted by Kemeng Shi 2 years, 6 months ago


on 7/20/2023 2:08 PM, Baolin Wang wrote:
> 
> 
> On 7/20/2023 7:53 PM, Kemeng Shi wrote:
>> Hi all, this series contains two random cleanups for compaction.
>> Patch 1 correct wrong comment in fast_isolate_freepages.
>> Patch 2 avoid to call unneeded pageblock_end_pfn when no_set_skip_hint
>> is set.
>> Thanks!
> 
> I only received the patch 2 in this patch set, and I checked the lore
> archives[1], still did not find patch 1. You missed patch 1?
> 
> [1] https://lore.kernel.org/linux-mm/20230720115351.2039431-1-shikemeng@huaweicloud.com/
> 
>>
>> Kemeng Shi (2):
>>    mm/compaction: correct comment of candidate pfn in
>>      fast_isolate_freepages
>>    mm/compaction: avoid unneeded pageblock_end_pfn when no_set_skip_hint
>>      is set
>>
>>   mm/compaction.c | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
> 
> 
Hi Baolin, thanks for the review and for reminding me of this. I can recive the patch 1
in my mail client. There maybe some problem in my mail server. I also found there is
a whole patchset I have sent is missing in lcore archives. I will try to resend these
patches. Thanks a lot.

-- 
Best wishes
Kemeng Shi