[v1] tools: perf: Two typos have been corrected

[PATCH] tools: perf: Two typos have been corrected

Posted by Rong Qianfeng 2 years, 6 months ago

When wrapping code, use ';' better than using ',' which is more
in line with the coding habits of most engineers.

Signed-off-by: Rong Qianfeng <rongqianfeng@vivo.com>
---
 tools/perf/builtin-diff.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c
index e8a1b16aa5f8..57d300d8e570
--- a/tools/perf/builtin-diff.c
+++ b/tools/perf/builtin-diff.c
@@ -1915,8 +1915,8 @@ static int data_init(int argc, const char **argv)
 		struct perf_data *data = &d->data;
 
 		data->path  = use_default ? defaults[i] : argv[i];
-		data->mode  = PERF_DATA_MODE_READ,
-		data->force = force,
+		data->mode  = PERF_DATA_MODE_READ;
+		data->force = force;
 
 		d->idx  = i;
 	}
-- 
2.39.0

Re: [PATCH] tools: perf: Two typos have been corrected

Posted by Ian Rogers 2 years, 6 months ago

On Wed, Jul 19, 2023 at 8:40 PM Rong Qianfeng <rongqianfeng@vivo.com> wrote:
>
> When wrapping code, use ';' better than using ',' which is more
> in line with the coding habits of most engineers.
>
> Signed-off-by: Rong Qianfeng <rongqianfeng@vivo.com>

Snap: https://lore.kernel.org/lkml/20230706094635.1553-1-luhongfei@vivo.com/

Thanks,
Ian

> ---
>  tools/perf/builtin-diff.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c
> index e8a1b16aa5f8..57d300d8e570
> --- a/tools/perf/builtin-diff.c
> +++ b/tools/perf/builtin-diff.c
> @@ -1915,8 +1915,8 @@ static int data_init(int argc, const char **argv)
>                 struct perf_data *data = &d->data;
>
>                 data->path  = use_default ? defaults[i] : argv[i];
> -               data->mode  = PERF_DATA_MODE_READ,
> -               data->force = force,
> +               data->mode  = PERF_DATA_MODE_READ;
> +               data->force = force;
>
>                 d->idx  = i;
>         }
> --
> 2.39.0
>

Re: [PATCH] tools: perf: Two typos have been corrected

Posted by Arnaldo Carvalho de Melo 2 years, 6 months ago

Em Wed, Jul 19, 2023 at 09:32:57PM -0700, Ian Rogers escreveu:
> On Wed, Jul 19, 2023 at 8:40 PM Rong Qianfeng <rongqianfeng@vivo.com> wrote:
> >
> > When wrapping code, use ';' better than using ',' which is more
> > in line with the coding habits of most engineers.
> >
> > Signed-off-by: Rong Qianfeng <rongqianfeng@vivo.com>
> 
> Snap: https://lore.kernel.org/lkml/20230706094635.1553-1-luhongfei@vivo.com/

Applied the one from luhongfei@vivo.com,

Thanks,

- Arnaldo
 
> Thanks,
> Ian
> 
> > ---
> >  tools/perf/builtin-diff.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c
> > index e8a1b16aa5f8..57d300d8e570
> > --- a/tools/perf/builtin-diff.c
> > +++ b/tools/perf/builtin-diff.c
> > @@ -1915,8 +1915,8 @@ static int data_init(int argc, const char **argv)
> >                 struct perf_data *data = &d->data;
> >
> >                 data->path  = use_default ? defaults[i] : argv[i];
> > -               data->mode  = PERF_DATA_MODE_READ,
> > -               data->force = force,
> > +               data->mode  = PERF_DATA_MODE_READ;
> > +               data->force = force;
> >
> >                 d->idx  = i;
> >         }
> > --
> > 2.39.0
> >

-- 

- Arnaldo