soc: apple: apple-pmgr-pwrstate: mark apple_pmgr_reset_ops static

[PATCH] soc: apple: apple-pmgr-pwrstate: mark apple_pmgr_reset_ops static

Posted by Min-Hua Chen 2 years, 6 months ago

This patch fixes the following sparse warnings:

drivers/soc/apple/apple-pmgr-pwrstate.c:180:32: sparse: warning: symbol 'apple_pmgr_reset_ops' was not declared. Should it be static?

No functional change intended.

Signed-off-by: Min-Hua Chen <minhuadotchen@gmail.com>
---
 drivers/soc/apple/apple-pmgr-pwrstate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/apple/apple-pmgr-pwrstate.c b/drivers/soc/apple/apple-pmgr-pwrstate.c
index d62a776c89a1..9467235110f4 100644
--- a/drivers/soc/apple/apple-pmgr-pwrstate.c
+++ b/drivers/soc/apple/apple-pmgr-pwrstate.c
@@ -177,7 +177,7 @@ static int apple_pmgr_reset_status(struct reset_controller_dev *rcdev, unsigned
 	return !!(reg & APPLE_PMGR_RESET);
 }
 
-const struct reset_control_ops apple_pmgr_reset_ops = {
+static const struct reset_control_ops apple_pmgr_reset_ops = {
 	.assert		= apple_pmgr_reset_assert,
 	.deassert	= apple_pmgr_reset_deassert,
 	.reset		= apple_pmgr_reset_reset,
-- 
2.34.1

Re: [PATCH] soc: apple: apple-pmgr-pwrstate: mark apple_pmgr_reset_ops static

Posted by Sven Peter 2 years, 6 months ago


On Thu, Jul 20, 2023, at 00:38, Min-Hua Chen wrote:
> This patch fixes the following sparse warnings:
>
> drivers/soc/apple/apple-pmgr-pwrstate.c:180:32: sparse: warning: symbol 
> 'apple_pmgr_reset_ops' was not declared. Should it be static?
>
> No functional change intended.
>
> Signed-off-by: Min-Hua Chen <minhuadotchen@gmail.com>
> ---

Acked-by: Sven Peter <sven@svenpeter.dev>


Thanks,


Sven

>  drivers/soc/apple/apple-pmgr-pwrstate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/apple/apple-pmgr-pwrstate.c 
> b/drivers/soc/apple/apple-pmgr-pwrstate.c
> index d62a776c89a1..9467235110f4 100644
> --- a/drivers/soc/apple/apple-pmgr-pwrstate.c
> +++ b/drivers/soc/apple/apple-pmgr-pwrstate.c
> @@ -177,7 +177,7 @@ static int apple_pmgr_reset_status(struct 
> reset_controller_dev *rcdev, unsigned
>  	return !!(reg & APPLE_PMGR_RESET);
>  }
> 
> -const struct reset_control_ops apple_pmgr_reset_ops = {
> +static const struct reset_control_ops apple_pmgr_reset_ops = {
>  	.assert		= apple_pmgr_reset_assert,
>  	.deassert	= apple_pmgr_reset_deassert,
>  	.reset		= apple_pmgr_reset_reset,
> -- 
> 2.34.1