Fix some 'perf trace' leaks found with -fsanitize=address.

[PATCHES 0/6] Fix some 'perf trace' leaks found with -fsanitize=address.

Posted by Arnaldo Carvalho de Melo 2 years, 6 months ago

Hi,

	Please review/ack, I put it as well on the tmp.perf-tools-next
in the perf-tools-next tree:

https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/commit/?h=tmp.perf-tools-next

Best regards,

- Arnaldo

Arnaldo Carvalho de Melo (6):
  perf evsel: Free evsel->filter on the destructor
  perf thread: Allow tools to register a thread->priv destructor
  perf trace: Register a thread priv destructor
  perf trace: Really free the evsel->priv area
  perf trace: Free thread_trace->files table
  MAINTAINERS: Add git information for perf-tools and perf-tools-next
    trees/branches

 MAINTAINERS                |  2 ++
 tools/perf/builtin-trace.c | 38 +++++++++++++++++++++++++++++++-------
 tools/perf/util/evsel.c    |  1 +
 tools/perf/util/thread.c   | 11 +++++++++++
 tools/perf/util/thread.h   |  2 ++
 5 files changed, 47 insertions(+), 7 deletions(-)

-- 
2.41.0

Re: [PATCHES 0/6] Fix some 'perf trace' leaks found with -fsanitize=address.

Posted by Ian Rogers 2 years, 6 months ago

On Wed, Jul 19, 2023 at 1:30 PM Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> Hi,
>
>         Please review/ack, I put it as well on the tmp.perf-tools-next
> in the perf-tools-next tree:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/commit/?h=tmp.perf-tools-next
>
> Best regards,
>
> - Arnaldo
>
> Arnaldo Carvalho de Melo (6):
>   perf evsel: Free evsel->filter on the destructor
>   perf thread: Allow tools to register a thread->priv destructor
>   perf trace: Register a thread priv destructor
>   perf trace: Really free the evsel->priv area
>   perf trace: Free thread_trace->files table
>   MAINTAINERS: Add git information for perf-tools and perf-tools-next
>     trees/branches

Series:
Acked-by: Ian Rogers <irogers@google.com>

I think patch 2 could use an extra assert to be extra safe.

Thanks,
Ian

>  MAINTAINERS                |  2 ++
>  tools/perf/builtin-trace.c | 38 +++++++++++++++++++++++++++++++-------
>  tools/perf/util/evsel.c    |  1 +
>  tools/perf/util/thread.c   | 11 +++++++++++
>  tools/perf/util/thread.h   |  2 ++
>  5 files changed, 47 insertions(+), 7 deletions(-)
>
> --
> 2.41.0
>