[PATCH] block: refactor to use helper

Nitesh Shetty posted 1 patch 2 years, 6 months ago
block/bio-integrity.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
[PATCH] block: refactor to use helper
Posted by Nitesh Shetty 2 years, 6 months ago
Reduce some code by making use of bio_integrity_bytes().

Signed-off-by: Nitesh Shetty <nj.shetty@samsung.com>
---
 block/bio-integrity.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/block/bio-integrity.c b/block/bio-integrity.c
index 4533eb491661..8f0af7ac8573 100644
--- a/block/bio-integrity.c
+++ b/block/bio-integrity.c
@@ -199,7 +199,6 @@ bool bio_integrity_prep(struct bio *bio)
 	unsigned long start, end;
 	unsigned int len, nr_pages;
 	unsigned int bytes, offset, i;
-	unsigned int intervals;
 	blk_status_t status;
 
 	if (!bi)
@@ -224,10 +223,9 @@ bool bio_integrity_prep(struct bio *bio)
 		    !(bi->flags & BLK_INTEGRITY_GENERATE))
 			return true;
 	}
-	intervals = bio_integrity_intervals(bi, bio_sectors(bio));
 
 	/* Allocate kernel buffer for protection data */
-	len = intervals * bi->tuple_size;
+	len = bio_integrity_bytes(bi, bio_sectors(bio));
 	buf = kmalloc(len, GFP_NOIO);
 	status = BLK_STS_RESOURCE;
 	if (unlikely(buf == NULL)) {
-- 
2.34.1
Re: [PATCH] block: refactor to use helper
Posted by Jens Axboe 2 years, 6 months ago
On Wed, 19 Jul 2023 17:46:08 +0530, Nitesh Shetty wrote:
> Reduce some code by making use of bio_integrity_bytes().
> 
> 

Applied, thanks!

[1/1] block: refactor to use helper
      commit: 8f63fef5867fb5e8c29d9c14b6d739bfc1869d32

Best regards,
-- 
Jens Axboe
Re: [PATCH] block: refactor to use helper
Posted by Martin K. Petersen 2 years, 6 months ago
Nitesh,

> Reduce some code by making use of bio_integrity_bytes().

Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering