The drivers in this subsystem are for character-based LCD displays, which
can fall into the same category of the DRM/KMS and fbdev drivers that are
located under the "Graphics support" menu. Add auxdisplay there as well.
Suggested-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Tested-by: Arnd Bergmann <arnd@arndb.de>
---
(no changes since v5)
Changes in v5:
- Take the auxdisplay/Kconfig source out of "if HAS_IOMEM" (Geert Uytterhoeven).
drivers/Kconfig | 2 --
drivers/video/Kconfig | 2 ++
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/Kconfig b/drivers/Kconfig
index 514ae6b24cb2..496ca02ee18f 100644
--- a/drivers/Kconfig
+++ b/drivers/Kconfig
@@ -129,8 +129,6 @@ source "drivers/dma-buf/Kconfig"
source "drivers/dca/Kconfig"
-source "drivers/auxdisplay/Kconfig"
-
source "drivers/uio/Kconfig"
source "drivers/vfio/Kconfig"
diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index 8b2b9ac37c3d..e5b1cc54cafa 100644
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig
@@ -25,6 +25,8 @@ config VIDEO_NOMODESET
bool
default n
+source "drivers/auxdisplay/Kconfig"
+
if HAS_IOMEM
config HAVE_FB_ATMEL
--
2.41.0Javier Martinez Canillas <javierm@redhat.com> writes: [adding Miguel Ojeda who was not in the Cc list] Hello Miguel, could you please ack this patch so that I can take the whole patch-set through the drm-misc tree? > The drivers in this subsystem are for character-based LCD displays, which > can fall into the same category of the DRM/KMS and fbdev drivers that are > located under the "Graphics support" menu. Add auxdisplay there as well. > > Suggested-by: Thomas Zimmermann <tzimmermann@suse.de> > Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> > Reviewed-by: Arnd Bergmann <arnd@arndb.de> > Tested-by: Arnd Bergmann <arnd@arndb.de> > --- > > (no changes since v5) > > Changes in v5: > - Take the auxdisplay/Kconfig source out of "if HAS_IOMEM" (Geert Uytterhoeven). > > drivers/Kconfig | 2 -- > drivers/video/Kconfig | 2 ++ > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/Kconfig b/drivers/Kconfig > index 514ae6b24cb2..496ca02ee18f 100644 > --- a/drivers/Kconfig > +++ b/drivers/Kconfig > @@ -129,8 +129,6 @@ source "drivers/dma-buf/Kconfig" > > source "drivers/dca/Kconfig" > > -source "drivers/auxdisplay/Kconfig" > - > source "drivers/uio/Kconfig" > > source "drivers/vfio/Kconfig" > diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig > index 8b2b9ac37c3d..e5b1cc54cafa 100644 > --- a/drivers/video/Kconfig > +++ b/drivers/video/Kconfig > @@ -25,6 +25,8 @@ config VIDEO_NOMODESET > bool > default n > > +source "drivers/auxdisplay/Kconfig" > + > if HAS_IOMEM > > config HAVE_FB_ATMEL > -- > 2.41.0 > -- Best regards, Javier Martinez Canillas Core Platforms Red Hat
On Sat, Jul 22, 2023 at 12:46 AM Javier Martinez Canillas
<javierm@redhat.com> wrote:
>
> Javier Martinez Canillas <javierm@redhat.com> writes:
>
> [adding Miguel Ojeda who was not in the Cc list]
>
> Hello Miguel, could you please ack this patch so that I can take the whole
> patch-set through the drm-misc tree?
A note below...
> > The drivers in this subsystem are for character-based LCD displays, which
> > can fall into the same category of the DRM/KMS and fbdev drivers that are
> > located under the "Graphics support" menu. Add auxdisplay there as well.
Nit: this is not exactly true, e.g. ks0108/cfag12864b (which were the
first in the subsystem) were not character-based but a very simple
black-or-white 128x64 grid, so we should probably reword slightly
this.
In any case, if Helge thinks these may belong in the "Graphics
support" menu, then I am fine with it:
Acked-by: Miguel Ojeda <ojeda@kernel.org>
Thanks!
Cheers,
Miguel
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> writes: Hello Miguel, > On Sat, Jul 22, 2023 at 12:46 AM Javier Martinez Canillas > <javierm@redhat.com> wrote: >> >> Javier Martinez Canillas <javierm@redhat.com> writes: >> >> [adding Miguel Ojeda who was not in the Cc list] >> >> Hello Miguel, could you please ack this patch so that I can take the whole >> patch-set through the drm-misc tree? > > A note below... > >> > The drivers in this subsystem are for character-based LCD displays, which >> > can fall into the same category of the DRM/KMS and fbdev drivers that are >> > located under the "Graphics support" menu. Add auxdisplay there as well. > > Nit: this is not exactly true, e.g. ks0108/cfag12864b (which were the > first in the subsystem) were not character-based but a very simple > black-or-white 128x64 grid, so we should probably reword slightly > this. > Oh, interesting. I wonder why that couldn't had been a fbdev driver then using FB_VISUAL_MONO01? I'll reword then the commit message before apply to the following instead: "The drivers in this subsystem are for either character-based or monochrome LCD controllers, which can fall into the same category of the DRM/KMS and fbdev drivers, that are located under the "Graphics support" menu. Add the auxdisplay drivers there as well to have all display drivers under the same menu." > In any case, if Helge thinks these may belong in the "Graphics > support" menu, then I am fine with it: > > Acked-by: Miguel Ojeda <ojeda@kernel.org> > Perfect, thanks! > Thanks! > > Cheers, > Miguel > -- Best regards, Javier Martinez Canillas Core Platforms Red Hat
On Sat, Jul 22, 2023 at 2:13 AM Javier Martinez Canillas
<javierm@redhat.com> wrote:
>
> Oh, interesting. I wonder why that couldn't had been a fbdev driver then
> using FB_VISUAL_MONO01? I'll reword then the commit message before apply
> to the following instead:
It is :)
.type = FB_TYPE_PACKED_PIXELS,
.visual = FB_VISUAL_MONO10,
The original distinction was more about having a place where to put
small, simple displays that were not your usual "screen", where you
would typically draw a custom UI, probably controlled with a few
custom buttons, etc.
> Perfect, thanks!
My pleasure!
Cheers,
Miguel
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> writes: > On Sat, Jul 22, 2023 at 2:13 AM Javier Martinez Canillas > <javierm@redhat.com> wrote: >> >> Oh, interesting. I wonder why that couldn't had been a fbdev driver then >> using FB_VISUAL_MONO01? I'll reword then the commit message before apply >> to the following instead: > > It is :) > > .type = FB_TYPE_PACKED_PIXELS, > .visual = FB_VISUAL_MONO10, > Ah! Should had read the driver before commenting then :) > The original distinction was more about having a place where to put > small, simple displays that were not your usual "screen", where you > would typically draw a custom UI, probably controlled with a few > custom buttons, etc. > Got it. Then that's yet another argument for adding the auxdisplay drivers under the same "Graphics support" menu. >> Perfect, thanks! > > My pleasure! > > Cheers, > Miguel > -- Best regards, Javier Martinez Canillas Core Platforms Red Hat
On Sat, Jul 22, 2023 at 2:50 AM Javier Martinez Canillas <javierm@redhat.com> wrote: > > Got it. Then that's yet another argument for adding the auxdisplay > drivers under the same "Graphics support" menu. Just in case it matters for Helge/you: these may also register an input device, e.g. the ht16k33 has a matrix keypad. Cheers, Miguel
© 2016 - 2026 Red Hat, Inc.