1. Patchew
  2. linux
  3. [PATCH v4 0/4] Add basic node support for MediaTek MT8188 SoC
  4. View patch

[PATCH v4 3/4] dt-bindings: soc: mediatek: pwrap: Modify compatible for MT8188

Jason-ch Chen posted 4 patches 1 year, 2 months ago
There is a newer version of this series
[PATCH v4 3/4] dt-bindings: soc: mediatek: pwrap: Modify compatible for MT8188
Posted by Jason-ch Chen 1 year, 2 months ago 
From: jason-ch chen <Jason-ch.Chen@mediatek.com>

The reason for changing the patch was that while MT8188 uses the same
pwrap as MT8195, the original code was only applicable to 'compatible =
"mediatek,mt8188-pwrap"'. To resolve the DTBS check warning that
'['mediatek,mt8188-pwrap', 'mediatek,mt8195-pwrap', 'syscon'] is too
long', it is necessary to modify the code.

Signed-off-by: jason-ch chen <Jason-ch.Chen@mediatek.com>
---
 .../devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml    | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
index a06ac2177444..4737e5f45d54 100644
--- a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
+++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
@@ -41,7 +41,6 @@ properties:
               - mediatek,mt8173-pwrap
               - mediatek,mt8183-pwrap
               - mediatek,mt8186-pwrap
-              - mediatek,mt8188-pwrap
               - mediatek,mt8195-pwrap
               - mediatek,mt8365-pwrap
               - mediatek,mt8516-pwrap
@@ -50,6 +49,11 @@ properties:
               - mediatek,mt8186-pwrap
               - mediatek,mt8195-pwrap
           - const: syscon
+      - items:
+          - enum:
+              - mediatek,mt8188-pwrap
+          - const: mediatek,mt8195-pwrap
+          - const: syscon
 
   reg:
     minItems: 1
-- 
2.18.0
Re: [PATCH v4 3/4] dt-bindings: soc: mediatek: pwrap: Modify compatible for MT8188
Posted by Conor Dooley 1 year, 2 months ago 
On Tue, Jul 18, 2023 at 07:09:46PM +0800, Jason-ch Chen wrote:
> From: jason-ch chen <Jason-ch.Chen@mediatek.com>
> 
> The reason for changing the patch was that while MT8188 uses the same
> pwrap as MT8195,

> the original code was only applicable to 'compatible =
> "mediatek,mt8188-pwrap"'.

I don't really understand what this means. Did you mean, "the original
binding only allowed..."? If so,
Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

> To resolve the DTBS check warning that
> '['mediatek,mt8188-pwrap', 'mediatek,mt8195-pwrap', 'syscon'] is too
> long', it is necessary to modify the code.
> 
> Signed-off-by: jason-ch chen <Jason-ch.Chen@mediatek.com>
> ---
>  .../devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml    | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> index a06ac2177444..4737e5f45d54 100644
> --- a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> +++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> @@ -41,7 +41,6 @@ properties:
>                - mediatek,mt8173-pwrap
>                - mediatek,mt8183-pwrap
>                - mediatek,mt8186-pwrap
> -              - mediatek,mt8188-pwrap
>                - mediatek,mt8195-pwrap
>                - mediatek,mt8365-pwrap
>                - mediatek,mt8516-pwrap
> @@ -50,6 +49,11 @@ properties:
>                - mediatek,mt8186-pwrap
>                - mediatek,mt8195-pwrap
>            - const: syscon
> +      - items:
> +          - enum:
> +              - mediatek,mt8188-pwrap
> +          - const: mediatek,mt8195-pwrap
> +          - const: syscon
>  
>    reg:
>      minItems: 1
> -- 
> 2.18.0
>
Re: [PATCH v4 3/4] dt-bindings: soc: mediatek: pwrap: Modify compatible for MT8188
Posted by Jason-ch Chen (陳建豪) 1 year, 2 months ago 
Hi Conor,

On Tue, 2023-07-18 at 16:13 +0100, Conor Dooley wrote:
> On Tue, Jul 18, 2023 at 07:09:46PM +0800, Jason-ch Chen wrote:
> > From: jason-ch chen <Jason-ch.Chen@mediatek.com>
> > 
> > The reason for changing the patch was that while MT8188 uses the
> > same
> > pwrap as MT8195,
> > the original code was only applicable to 'compatible =
> > "mediatek,mt8188-pwrap"'.
> 
> I don't really understand what this means. Did you mean, "the
> original
> binding only allowed..."? If so,
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> 

Thank you for your reply.
The actual test results confirm that the original binding is only
allowed to 'compatible = "mediatek,mt8188-pwrap"'.

> Thanks,
> Conor.
> 
> > To resolve the DTBS check warning that
> > '['mediatek,mt8188-pwrap', 'mediatek,mt8195-pwrap', 'syscon'] is
> > too
> > long', it is necessary to modify the code.
> > 
> > Signed-off-by: jason-ch chen <Jason-ch.Chen@mediatek.com>
> > ---
> >  .../devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml    | 6
> > +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yam
> > l
> > b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yam
> > l
> > index a06ac2177444..4737e5f45d54 100644
> > ---
> > a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yam
> > l
> > +++
> > b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yam
> > l
> > @@ -41,7 +41,6 @@ properties:
> >                - mediatek,mt8173-pwrap
> >                - mediatek,mt8183-pwrap
> >                - mediatek,mt8186-pwrap
> > -              - mediatek,mt8188-pwrap
> >                - mediatek,mt8195-pwrap
> >                - mediatek,mt8365-pwrap
> >                - mediatek,mt8516-pwrap
> > @@ -50,6 +49,11 @@ properties:
> >                - mediatek,mt8186-pwrap
> >                - mediatek,mt8195-pwrap
> >            - const: syscon
> > +      - items:
> > +          - enum:
> > +              - mediatek,mt8188-pwrap
> > +          - const: mediatek,mt8195-pwrap
> > +          - const: syscon
> >  
> >    reg:
> >      minItems: 1
> > -- 
> > 2.18.0

Regards,
Jason
Re: [PATCH v4 3/4] dt-bindings: soc: mediatek: pwrap: Modify compatible for MT8188
Posted by AngeloGioacchino Del Regno 1 year, 2 months ago 
Il 18/07/23 13:09, Jason-ch Chen ha scritto:
> From: jason-ch chen <Jason-ch.Chen@mediatek.com>
> 
> The reason for changing the patch was that while MT8188 uses the same
> pwrap as MT8195, the original code was only applicable to 'compatible =
> "mediatek,mt8188-pwrap"'. To resolve the DTBS check warning that
> '['mediatek,mt8188-pwrap', 'mediatek,mt8195-pwrap', 'syscon'] is too
> long', it is necessary to modify the code.
> 
> Signed-off-by: jason-ch chen <Jason-ch.Chen@mediatek.com>

The original binding allowed only "mediatek,mt8188-pwrap", while we need
to specify

compatible = "mediatek,mt8188-pwrap", "mediatek,mt8195-pwrap", "syscon";

for this node, as MT8188's PWRAP is fully compatible with MT8195 as it is
the very same IP, hence:

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

Regards,
Angelo

> ---
>   .../devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml    | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> index a06ac2177444..4737e5f45d54 100644
> --- a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> +++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> @@ -41,7 +41,6 @@ properties:
>                 - mediatek,mt8173-pwrap
>                 - mediatek,mt8183-pwrap
>                 - mediatek,mt8186-pwrap
> -              - mediatek,mt8188-pwrap
>                 - mediatek,mt8195-pwrap
>                 - mediatek,mt8365-pwrap
>                 - mediatek,mt8516-pwrap
> @@ -50,6 +49,11 @@ properties:
>                 - mediatek,mt8186-pwrap
>                 - mediatek,mt8195-pwrap
>             - const: syscon
> +      - items:
> +          - enum:
> +              - mediatek,mt8188-pwrap
> +          - const: mediatek,mt8195-pwrap
> +          - const: syscon
>   
>     reg:
>       minItems: 1

Patchew 2.1-devel-b67e4c2

© 2016 - 2024 Red Hat, Inc.