[v2] hwmon: (oxp-sensors) Refactor probe() and init() and remove devm_add_groups()

[PATCH v2 0/2] hwmon: (oxp-sensors) Refactor probe() and init() and remove devm_add_groups()

Joaquín Ignacio Aramendía posted 2 patches 2 years, 6 months ago

Diff against v1
Download series mbox

drivers/hwmon/oxp-sensors.c | 67 +++++++++++++++++++++----------------
1 file changed, 39 insertions(+), 28 deletions(-)

Expand all Fold all

[PATCH v2 0/2] hwmon: (oxp-sensors) Refactor probe() and init() and remove devm_add_groups()

Posted by Joaquín Ignacio Aramendía 2 years, 6 months ago

Remove the use of devm_add_groups() in favour of dev_groups in platform
driver structure. This will allow for removal of the function as it was
intended in Greg's email[1].

Also move board detection to the init() instead of probe() function so we
don't instantiate the driver if the detection fails.

V2 drops the 3rd patch that removed the probe() function.

[1] Link: https://lore.kernel.org/linux-hwmon/ZKW7WuP0T9QdCR+G@google.com/

Joaquín Ignacio Aramendía (2):
  hwmon: (oxp-sensors) Move tt_toggle attribute to dev_groups
  hwmon: (oxp-sensors) Move board detection to the init function

 drivers/hwmon/oxp-sensors.c | 67 +++++++++++++++++++++----------------
 1 file changed, 39 insertions(+), 28 deletions(-)

-- 
2.41.0