[PATCH] gpio: bcm-kona: remove unneeded platform_set_drvdata() call

Andrei Coardos posted 1 patch 2 years, 6 months ago
drivers/gpio/gpio-bcm-kona.c | 1 -
1 file changed, 1 deletion(-)
[PATCH] gpio: bcm-kona: remove unneeded platform_set_drvdata() call
Posted by Andrei Coardos 2 years, 6 months ago
The platform_set_drvdata() call was never used, ever since the driver was
originally added.
It looks like this copy+paste left-over. Possibly the author copied from a
driver that had this line, but also had a remove hook.

Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
---
 drivers/gpio/gpio-bcm-kona.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpio/gpio-bcm-kona.c b/drivers/gpio/gpio-bcm-kona.c
index 70770429ba48..2e50a07a43e6 100644
--- a/drivers/gpio/gpio-bcm-kona.c
+++ b/drivers/gpio/gpio-bcm-kona.c
@@ -597,7 +597,6 @@ static int bcm_kona_gpio_probe(struct platform_device *pdev)
 		return -ENOMEM;
 
 	kona_gpio->pdev = pdev;
-	platform_set_drvdata(pdev, kona_gpio);
 	chip->parent = dev;
 	chip->ngpio = kona_gpio->num_bank * GPIO_PER_BANK;
 
-- 
2.34.1
Re: [PATCH] gpio: bcm-kona: remove unneeded platform_set_drvdata() call
Posted by Andy Shevchenko 2 years, 6 months ago
On Mon, Jul 17, 2023 at 03:55:21PM +0300, Andrei Coardos wrote:
> The platform_set_drvdata() call was never used, ever since the driver was
> originally added.
> It looks like this copy+paste left-over. Possibly the author copied from a
> driver that had this line, but also had a remove hook.

Cool, I'll incorporate this into my series. I'll make it as v2 to avoid clashes
with this one.

-- 
With Best Regards,
Andy Shevchenko