From: jason-ch chen <Jason-ch.Chen@mediatek.com>
Add MT8188 PMIC Wrapper compatible to binding document.
Signed-off-by: jason-ch chen <Jason-ch.Chen@mediatek.com>
---
.../devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
index a06ac2177444..4737e5f45d54 100644
--- a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
+++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
@@ -41,7 +41,6 @@ properties:
- mediatek,mt8173-pwrap
- mediatek,mt8183-pwrap
- mediatek,mt8186-pwrap
- - mediatek,mt8188-pwrap
- mediatek,mt8195-pwrap
- mediatek,mt8365-pwrap
- mediatek,mt8516-pwrap
@@ -50,6 +49,11 @@ properties:
- mediatek,mt8186-pwrap
- mediatek,mt8195-pwrap
- const: syscon
+ - items:
+ - enum:
+ - mediatek,mt8188-pwrap
+ - const: mediatek,mt8195-pwrap
+ - const: syscon
reg:
minItems: 1
--
2.18.0On 17/07/2023 14:02, Jason-ch Chen wrote: > From: jason-ch chen <Jason-ch.Chen@mediatek.com> > > Add MT8188 PMIC Wrapper compatible to binding document. No improvements here - the compatible is already there. Subject has the same issue. Explain what you are doing and why. > > Signed-off-by: jason-ch chen <Jason-ch.Chen@mediatek.com> > --- > .../devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml > index a06ac2177444..4737e5f45d54 100644 > --- a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml > +++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml > @@ -41,7 +41,6 @@ properties: > - mediatek,mt8173-pwrap > - mediatek,mt8183-pwrap > - mediatek,mt8186-pwrap > - - mediatek,mt8188-pwrap Look, here ^^^^ > - mediatek,mt8195-pwrap > - mediatek,mt8365-pwrap > - mediatek,mt8516-pwrap > @@ -50,6 +49,11 @@ properties: > - mediatek,mt8186-pwrap > - mediatek,mt8195-pwrap > - const: syscon > + - items: > + - enum: > + - mediatek,mt8188-pwrap Best regards, Krzysztof
Hi Krzysztof, On Mon, 2023-07-17 at 21:55 +0200, Krzysztof Kozlowski wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > On 17/07/2023 14:02, Jason-ch Chen wrote: > > From: jason-ch chen <Jason-ch.Chen@mediatek.com> > > > > Add MT8188 PMIC Wrapper compatible to binding document. > > No improvements here - the compatible is already there. Subject has > the > same issue. Explain what you are doing and why. The reason for changing the patch was that while MT8188 uses the same pwrap as MT8195, the original code was applicable to 'compatible = "mediatek,mt8188-pwrap"'. To resolve the DTBS check warning that '['mediatek,mt8188-pwrap', 'mediatek,mt8195-pwrap', 'syscon'] is too long', I modified the code as per the current patch. > > > > > Signed-off-by: jason-ch chen <Jason-ch.Chen@mediatek.com> > > --- > > .../devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml | 6 > +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git > a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml > b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml > > index a06ac2177444..4737e5f45d54 100644 > > --- > a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml > > +++ > b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml > > @@ -41,7 +41,6 @@ properties: > > - mediatek,mt8173-pwrap > > - mediatek,mt8183-pwrap > > - mediatek,mt8186-pwrap > > - - mediatek,mt8188-pwrap > > Look, here ^^^^ > > > - mediatek,mt8195-pwrap > > - mediatek,mt8365-pwrap > > - mediatek,mt8516-pwrap > > @@ -50,6 +49,11 @@ properties: > > - mediatek,mt8186-pwrap > > - mediatek,mt8195-pwrap > > - const: syscon > > + - items: > > + - enum: > > + - mediatek,mt8188-pwrap > > > Best regards, > Krzysztof Thanks, Jason >
On 18/07/2023 08:34, Jason-ch Chen (陳建豪) wrote: > Hi Krzysztof, > > On Mon, 2023-07-17 at 21:55 +0200, Krzysztof Kozlowski wrote: >> >> External email : Please do not click links or open attachments until >> you have verified the sender or the content. >> On 17/07/2023 14:02, Jason-ch Chen wrote: >>> From: jason-ch chen <Jason-ch.Chen@mediatek.com> >>> >>> Add MT8188 PMIC Wrapper compatible to binding document. >> >> No improvements here - the compatible is already there. Subject has >> the >> same issue. Explain what you are doing and why. > > The reason for changing the patch was that while MT8188 uses the same > pwrap as MT8195, the original code was applicable to 'compatible = > "mediatek,mt8188-pwrap"'. > > To resolve the DTBS check warning that '['mediatek,mt8188-pwrap', > 'mediatek,mt8195-pwrap', 'syscon'] is too long', I modified the code as > per the current patch. Explain it in commit msg. Fix the subject in new patch. Best regards, Krzysztof
Hi Krzysztof, On Tue, 2023-07-18 at 08:36 +0200, Krzysztof Kozlowski wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > On 18/07/2023 08:34, Jason-ch Chen (陳建豪) wrote: > > Hi Krzysztof, > > > > On Mon, 2023-07-17 at 21:55 +0200, Krzysztof Kozlowski wrote: > >> > >> External email : Please do not click links or open attachments > until > >> you have verified the sender or the content. > >> On 17/07/2023 14:02, Jason-ch Chen wrote: > >>> From: jason-ch chen <Jason-ch.Chen@mediatek.com> > >>> > >>> Add MT8188 PMIC Wrapper compatible to binding document. > >> > >> No improvements here - the compatible is already there. Subject > has > >> the > >> same issue. Explain what you are doing and why. > > > > The reason for changing the patch was that while MT8188 uses the > same > > pwrap as MT8195, the original code was applicable to 'compatible = > > "mediatek,mt8188-pwrap"'. > > > > To resolve the DTBS check warning that '['mediatek,mt8188-pwrap', > > 'mediatek,mt8195-pwrap', 'syscon'] is too long', I modified the > code as > > per the current patch. > > Explain it in commit msg. Fix the subject in new patch. Thank you for your kind response. In the next version, I will explain it and correct the subject accordingly. > > Best regards, > Krzysztof > Regards, Jason
© 2016 - 2024 Red Hat, Inc.