[v2] wifi: ath9k: Remove error checking for debugfs_create_dir()

[PATCH net v2] wifi: ath9k: Remove error checking for debugfs_create_dir()

Wang Ming posted 1 patch 2 years, 6 months ago

Diff against v3
Download mbox

There is a newer version of this series

drivers/net/wireless/ath/ath9k/htc_drv_debug.c | 2 --
1 file changed, 2 deletions(-)

Expand all Fold all

[PATCH net v2] wifi: ath9k: Remove error checking for debugfs_create_dir()

Posted by Wang Ming 2 years, 6 months ago

It is expected that most callers should _ignore_ the errors
return by debugfs_create_dir() in ath9k_htc_init_debug().

Signed-off-by: Wang Ming <machel@vivo.com>
---
 drivers/net/wireless/ath/ath9k/htc_drv_debug.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_debug.c b/drivers/net/wireless/ath/ath9k/htc_drv_debug.c
index b3ed65e5c4da..85ad45771b44 100644
--- a/drivers/net/wireless/ath/ath9k/htc_drv_debug.c
+++ b/drivers/net/wireless/ath/ath9k/htc_drv_debug.c
@@ -491,8 +491,6 @@ int ath9k_htc_init_debug(struct ath_hw *ah)
 
 	priv->debug.debugfs_phy = debugfs_create_dir(KBUILD_MODNAME,
 					     priv->hw->wiphy->debugfsdir);
-	if (!priv->debug.debugfs_phy)
-		return -ENOMEM;
 
 	ath9k_cmn_spectral_init_debug(&priv->spec_priv, priv->debug.debugfs_phy);
 
-- 
2.25.1

Re: [PATCH net v2] wifi: ath9k: Remove error checking for debugfs_create_dir()

Posted by Kalle Valo 2 years, 6 months ago

Wang Ming <machel@vivo.com> writes:

> It is expected that most callers should _ignore_ the errors
> return by debugfs_create_dir() in ath9k_htc_init_debug().
>
> Signed-off-by: Wang Ming <machel@vivo.com>

This is not urgent and should go to ath-next, not to the net tree.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches