[PATCH net v3] wifi: ath6kl: Remove error checking for debugfs_create_dir()

Wang Ming posted 1 patch 2 years, 6 months ago
There is a newer version of this series
drivers/net/wireless/ath/ath6kl/debug.c | 2 --
1 file changed, 2 deletions(-)
[PATCH net v3] wifi: ath6kl: Remove error checking for debugfs_create_dir()
Posted by Wang Ming 2 years, 6 months ago
It is expected that most callers should _ignore_ the errors
return by debugfs_create_dir() in ath6kl_debug_init_fs().

Signed-off-by: Wang Ming <machel@vivo.com>
---
 drivers/net/wireless/ath/ath6kl/debug.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/wireless/ath/ath6kl/debug.c b/drivers/net/wireless/ath/ath6kl/debug.c
index 433a047f3747..b837d31416df 100644
--- a/drivers/net/wireless/ath/ath6kl/debug.c
+++ b/drivers/net/wireless/ath/ath6kl/debug.c
@@ -1793,8 +1793,6 @@ int ath6kl_debug_init_fs(struct ath6kl *ar)
 {
 	ar->debugfs_phy = debugfs_create_dir("ath6kl",
 					     ar->wiphy->debugfsdir);
-	if (!ar->debugfs_phy)
-		return -ENOMEM;
 
 	debugfs_create_file("tgt_stats", 0400, ar->debugfs_phy, ar,
 			    &fops_tgt_stats);
-- 
2.25.1
Re: [PATCH net v3] wifi: ath6kl: Remove error checking for debugfs_create_dir()
Posted by Kalle Valo 2 years, 6 months ago
Wang Ming <machel@vivo.com> wrote:

> It is expected that most callers should _ignore_ the errors
> return by debugfs_create_dir() in ath6kl_debug_init_fs().
> 
> Signed-off-by: Wang Ming <machel@vivo.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>

Patch applied to ath-next branch of ath.git, thanks.

1301783c8def wifi: ath6kl: Remove error checking for debugfs_create_dir()

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20230714014358.514-1-machel@vivo.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Re: [PATCH net v3] wifi: ath6kl: Remove error checking for debugfs_create_dir()
Posted by Kalle Valo 2 years, 6 months ago
Wang Ming <machel@vivo.com> writes:

> It is expected that most callers should _ignore_ the errors
> return by debugfs_create_dir() in ath6kl_debug_init_fs().
>
> Signed-off-by: Wang Ming <machel@vivo.com>

This should go to ath-next, not net.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches