[v4] selftests/resctrl: Fixes and cleanups

[PATCH v4 01/19] selftests/resctrl: Add resctrl.h into build deps

Posted by Ilpo Järvinen 2 years, 6 months ago

Makefile only lists *.c as build dependencies for the resctrl_tests
executable which excludes resctrl.h.

Add *.h to wildcard() to include resctrl.h.

Fixes: 591a6e8588fc ("selftests/resctrl: Add basic resctrl file system operations and data")
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
---
 tools/testing/selftests/resctrl/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/resctrl/Makefile b/tools/testing/selftests/resctrl/Makefile
index 73d53257df42..5073dbc96125 100644
--- a/tools/testing/selftests/resctrl/Makefile
+++ b/tools/testing/selftests/resctrl/Makefile
@@ -7,4 +7,4 @@ TEST_GEN_PROGS := resctrl_tests
 
 include ../lib.mk
 
-$(OUTPUT)/resctrl_tests: $(wildcard *.c)
+$(OUTPUT)/resctrl_tests: $(wildcard *.[ch])
-- 
2.30.2

Re: [PATCH v4 01/19] selftests/resctrl: Add resctrl.h into build deps

Posted by Reinette Chatre 2 years, 6 months ago

Hi Ilpo,

On 7/13/2023 6:19 AM, Ilpo Järvinen wrote:
> Makefile only lists *.c as build dependencies for the resctrl_tests
> executable which excludes resctrl.h.
> 
> Add *.h to wildcard() to include resctrl.h.
> 
> Fixes: 591a6e8588fc ("selftests/resctrl: Add basic resctrl file system operations and data")
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

Thank you.

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette