[PATCH 2/2] arm64: dts: qcom: ipq9574: add support for the RDP417 variant

Sridharan S N posted 2 patches 2 years, 7 months ago
There is a newer version of this series
[PATCH 2/2] arm64: dts: qcom: ipq9574: add support for the RDP417 variant
Posted by Sridharan S N 2 years, 7 months ago
Add the initial device tree support for the Reference Design
Platform(RDP) 417 based on IPQ9574 family of SoC.

This patch depends on below patchset:
https://lore.kernel.org/lkml/20230713105909.14209-2-quic_anusha@quicinc.com/

Signed-off-by: Sridharan S N <quic_sridsn@quicinc.com>
---
 arch/arm64/boot/dts/qcom/Makefile           |  1 +
 arch/arm64/boot/dts/qcom/ipq9574-rdp417.dts | 16 ++++++++++++++++
 2 files changed, 17 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/ipq9574-rdp417.dts

diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index 337abc4ceb17..9c30344d08c1 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -12,6 +12,7 @@ dtb-$(CONFIG_ARCH_QCOM)	+= ipq6018-cp01-c1.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= ipq8074-hk01.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= ipq8074-hk10-c1.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= ipq8074-hk10-c2.dtb
+dtb-$(CONFIG_ARCH_QCOM)	+= ipq9574-rdp417.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= ipq9574-rdp418.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= ipq9574-rdp433.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= ipq9574-rdp449.dtb
diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp417.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp417.dts
new file mode 100644
index 000000000000..9a5d4c3db1f2
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp417.dts
@@ -0,0 +1,16 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
+/*
+ * IPQ9574 RDP417 board device tree source
+ *
+ * Copyright (c) 2020-2021 The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
+ */
+
+/dts-v1/;
+
+#include "ipq9574-rdp-common.dtsi"
+
+/ {
+	model = "Qualcomm Technologies, Inc. IPQ9574/AP-AL01-C1";
+	compatible = "qcom,ipq9574-ap-al01-c1", "qcom,ipq9574";
+};
-- 
2.34.1
Re: [PATCH 2/2] arm64: dts: qcom: ipq9574: add support for the RDP417 variant
Posted by Krzysztof Kozlowski 2 years, 7 months ago
On 13/07/2023 13:55, Sridharan S N wrote:
> Add the initial device tree support for the Reference Design
> Platform(RDP) 417 based on IPQ9574 family of SoC.
> 
> This patch depends on below patchset:
> https://lore.kernel.org/lkml/20230713105909.14209-2-quic_anusha@quicinc.com/

This does not make sense in commit log. Why would you store it in commit
in the first place? Please put dependencies with changelog, so after ---
separator.

Best regards,
Krzysztof
Re: [PATCH 2/2] arm64: dts: qcom: ipq9574: add support for the RDP417 variant
Posted by Sridharan S N 2 years, 7 months ago
On 7/13/2023 5:28 PM, Krzysztof Kozlowski wrote:
> On 13/07/2023 13:55, Sridharan S N wrote:
>> Add the initial device tree support for the Reference Design
>> Platform(RDP) 417 based on IPQ9574 family of SoC.
>>
>> This patch depends on below patchset:
>> https://lore.kernel.org/lkml/20230713105909.14209-2-quic_anusha@quicinc.com/
> This does not make sense in commit log. Why would you store it in commit
> in the first place? Please put dependencies with changelog, so after ---
> separator.
>
> Best regards,
> Krzysztof

Sorry,I overlooked it. Will move the dependencies to change log and post v2


Thanks,

Sridharan

>