mmc: renesas_sdhi: remove outdated indentation

[PATCH] mmc: renesas_sdhi: remove outdated indentation

Posted by Wolfram Sang 2 years, 7 months ago

Using tabs to make a structure initialization more readable is not
considered helpful. Remove the final appearance from this driver.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---

My eyes always stumble over this...

 drivers/mmc/host/renesas_sdhi_core.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c
index 2d5ef9c37d76..10dbdb4abc93 100644
--- a/drivers/mmc/host/renesas_sdhi_core.c
+++ b/drivers/mmc/host/renesas_sdhi_core.c
@@ -983,12 +983,12 @@ int renesas_sdhi_probe(struct platform_device *pdev,
 
 	}
 
-	host->write16_hook	= renesas_sdhi_write16_hook;
-	host->clk_enable	= renesas_sdhi_clk_enable;
-	host->clk_disable	= renesas_sdhi_clk_disable;
-	host->set_clock		= renesas_sdhi_set_clock;
-	host->multi_io_quirk	= renesas_sdhi_multi_io_quirk;
-	host->dma_ops		= dma_ops;
+	host->write16_hook = renesas_sdhi_write16_hook;
+	host->clk_enable = renesas_sdhi_clk_enable;
+	host->clk_disable = renesas_sdhi_clk_disable;
+	host->set_clock = renesas_sdhi_set_clock;
+	host->multi_io_quirk = renesas_sdhi_multi_io_quirk;
+	host->dma_ops = dma_ops;
 
 	if (sdhi_has_quirk(priv, hs400_disabled))
 		host->mmc->caps2 &= ~(MMC_CAP2_HS400 | MMC_CAP2_HS400_ES);
-- 
2.30.2

Re: [PATCH] mmc: renesas_sdhi: remove outdated indentation

Posted by Geert Uytterhoeven 2 years, 7 months ago

On Wed, Jul 12, 2023 at 4:05 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> Using tabs to make a structure initialization more readable is not
> considered helpful. Remove the final appearance from this driver.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] mmc: renesas_sdhi: remove outdated indentation

Posted by Ulf Hansson 2 years, 6 months ago

On Wed, 12 Jul 2023 at 16:01, Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
>
> Using tabs to make a structure initialization more readable is not
> considered helpful. Remove the final appearance from this driver.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>
> My eyes always stumble over this...
>
>  drivers/mmc/host/renesas_sdhi_core.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c
> index 2d5ef9c37d76..10dbdb4abc93 100644
> --- a/drivers/mmc/host/renesas_sdhi_core.c
> +++ b/drivers/mmc/host/renesas_sdhi_core.c
> @@ -983,12 +983,12 @@ int renesas_sdhi_probe(struct platform_device *pdev,
>
>         }
>
> -       host->write16_hook      = renesas_sdhi_write16_hook;
> -       host->clk_enable        = renesas_sdhi_clk_enable;
> -       host->clk_disable       = renesas_sdhi_clk_disable;
> -       host->set_clock         = renesas_sdhi_set_clock;
> -       host->multi_io_quirk    = renesas_sdhi_multi_io_quirk;
> -       host->dma_ops           = dma_ops;
> +       host->write16_hook = renesas_sdhi_write16_hook;
> +       host->clk_enable = renesas_sdhi_clk_enable;
> +       host->clk_disable = renesas_sdhi_clk_disable;
> +       host->set_clock = renesas_sdhi_set_clock;
> +       host->multi_io_quirk = renesas_sdhi_multi_io_quirk;
> +       host->dma_ops = dma_ops;
>
>         if (sdhi_has_quirk(priv, hs400_disabled))
>                 host->mmc->caps2 &= ~(MMC_CAP2_HS400 | MMC_CAP2_HS400_ES);
> --
> 2.30.2
>