[PATCH v2] i2c: busses: fix parameter check in i2c_gpio_fault_injector_init()

Minjie Du posted 1 patch 2 years, 6 months ago
There is a newer version of this series
drivers/i2c/busses/i2c-gpio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH v2] i2c: busses: fix parameter check in i2c_gpio_fault_injector_init()
Posted by Minjie Du 2 years, 6 months ago
Make IS_ERR() judge the debugfs_create_dir() function return.

Signed-off-by: Minjie Du <duminjie@vivo.com>

v1-v2:
Fix judge typo.
---
 drivers/i2c/busses/i2c-gpio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-gpio.c b/drivers/i2c/busses/i2c-gpio.c
index e5a5b9e8b..545927b96 100644
--- a/drivers/i2c/busses/i2c-gpio.c
+++ b/drivers/i2c/busses/i2c-gpio.c
@@ -265,7 +265,7 @@ static void i2c_gpio_fault_injector_init(struct platform_device *pdev)
 	 */
 	if (!i2c_gpio_debug_dir) {
 		i2c_gpio_debug_dir = debugfs_create_dir("i2c-fault-injector", NULL);
-		if (!i2c_gpio_debug_dir)
+		if (IS_ERR(i2c_gpio_debug_dir))
 			return;
 	}
 
-- 
2.39.0
Re: [PATCH v2] i2c: busses: fix parameter check in i2c_gpio_fault_injector_init()
Posted by Andi Shyti 2 years, 6 months ago
Hi Minje,

On Wed, Jul 12, 2023 at 07:22:22PM +0800, Minjie Du wrote:
> Make IS_ERR() judge the debugfs_create_dir() function return.
> 
> Signed-off-by: Minjie Du <duminjie@vivo.com>
> 
> v1-v2:
> Fix judge typo.

Please next time add the changelog after the "---" section.

You will also need:

Fixes: 14911c6f48ec ("i2c: gpio: add fault injector")
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: <stable@vger.kernel.org> # v4.16+

Said that:

Reviewed-by: Andi Shyti <andi.shyti@kernel.org> 

Andi

> ---
>  drivers/i2c/busses/i2c-gpio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-gpio.c b/drivers/i2c/busses/i2c-gpio.c
> index e5a5b9e8b..545927b96 100644
> --- a/drivers/i2c/busses/i2c-gpio.c
> +++ b/drivers/i2c/busses/i2c-gpio.c
> @@ -265,7 +265,7 @@ static void i2c_gpio_fault_injector_init(struct platform_device *pdev)
>  	 */
>  	if (!i2c_gpio_debug_dir) {
>  		i2c_gpio_debug_dir = debugfs_create_dir("i2c-fault-injector", NULL);
> -		if (!i2c_gpio_debug_dir)
> +		if (IS_ERR(i2c_gpio_debug_dir))
>  			return;
>  	}
>  
> -- 
> 2.39.0
>