[PATCH] gpiolib: order includes alphabetically in gpiolib.h

Bartosz Golaszewski posted 1 patch 2 years, 6 months ago
drivers/gpio/gpiolib.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
[PATCH] gpiolib: order includes alphabetically in gpiolib.h
Posted by Bartosz Golaszewski 2 years, 6 months ago
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

After adding the missing notifier.h header, let's order all includes
alphabetically.

Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
 drivers/gpio/gpiolib.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpio/gpiolib.h b/drivers/gpio/gpiolib.h
index 1409d52487c0..7c562fbb9fb0 100644
--- a/drivers/gpio/gpiolib.h
+++ b/drivers/gpio/gpiolib.h
@@ -9,13 +9,13 @@
 #ifndef GPIOLIB_H
 #define GPIOLIB_H
 
-#include <linux/gpio/driver.h>
-#include <linux/gpio/consumer.h> /* for enum gpiod_flags */
-#include <linux/err.h>
+#include <linux/cdev.h>
 #include <linux/device.h>
+#include <linux/err.h>
+#include <linux/gpio/consumer.h> /* for enum gpiod_flags */
+#include <linux/gpio/driver.h>
 #include <linux/module.h>
 #include <linux/notifier.h>
-#include <linux/cdev.h>
 #include <linux/rwsem.h>
 
 #define GPIOCHIP_NAME	"gpiochip"
-- 
2.39.2
Re: [PATCH] gpiolib: order includes alphabetically in gpiolib.h
Posted by Linus Walleij 2 years, 6 months ago
On Wed, Jul 12, 2023 at 11:59 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:

> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> After adding the missing notifier.h header, let's order all includes
> alphabetically.
>
> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij
Re: [PATCH] gpiolib: order includes alphabetically in gpiolib.h
Posted by Andy Shevchenko 2 years, 6 months ago
On Wed, Jul 12, 2023 at 11:59:55AM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> After adding the missing notifier.h header, let's order all includes
> alphabetically.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

-- 
With Best Regards,
Andy Shevchenko