drivers/ufs/host/ufs-mediatek.c | 1 - 1 file changed, 1 deletion(-)
There is no need to call the dev_err() function directly to print a
custom message when handling an error from either the platform_get_irq()
or platform_get_irq_byname() functions as both are going to display an
appropriate error message in case of a failure.
./drivers/ufs/host/ufs-mediatek.c:864:3-10: line 864 is redundant because platform_get_irq() already prints an error
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5846
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/ufs/host/ufs-mediatek.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-mediatek.c
index 786b1469eb52..b499eade957e 100644
--- a/drivers/ufs/host/ufs-mediatek.c
+++ b/drivers/ufs/host/ufs-mediatek.c
@@ -861,7 +861,6 @@ static void ufs_mtk_init_mcq_irq(struct ufs_hba *hba)
irq = platform_get_irq(pdev, i + 1);
if (irq < 0) {
host->mcq_intr_info[i].irq = MTK_MCQ_INVALID_IRQ;
- dev_err(hba->dev, "get platform mcq irq fail: %d\n", i);
goto failed;
}
host->mcq_intr_info[i].hba = hba;
--
2.20.1.7.g153144c
Yang, > There is no need to call the dev_err() function directly to print a > custom message when handling an error from either the platform_get_irq() > or platform_get_irq_byname() functions as both are going to display an > appropriate error message in case of a failure. Applied to 6.6/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering
Il 12/07/23 08:48, Yang Li ha scritto: > There is no need to call the dev_err() function directly to print a > custom message when handling an error from either the platform_get_irq() > or platform_get_irq_byname() functions as both are going to display an > appropriate error message in case of a failure. > > ./drivers/ufs/host/ufs-mediatek.c:864:3-10: line 864 is redundant because platform_get_irq() already prints an error > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5846 > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
On Wed, Jul 12, 2023 at 02:48:32PM +0800, Yang Li wrote: > There is no need to call the dev_err() function directly to print a > custom message when handling an error from either the platform_get_irq() > or platform_get_irq_byname() functions as both are going to display an > appropriate error message in case of a failure. > > ./drivers/ufs/host/ufs-mediatek.c:864:3-10: line 864 is redundant because platform_get_irq() already prints an error > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5846 Acked-by: Sudeep Holla <sudeep.holla@arm.com> -- Regards, Sudeep
On Thu, Jul 13, 2023 at 02:11:23PM +0100, Sudeep Holla wrote: > On Wed, Jul 12, 2023 at 02:48:32PM +0800, Yang Li wrote: > > There is no need to call the dev_err() function directly to print a > > custom message when handling an error from either the platform_get_irq() > > or platform_get_irq_byname() functions as both are going to display an > > appropriate error message in case of a failure. > > > > ./drivers/ufs/host/ufs-mediatek.c:864:3-10: line 864 is redundant because platform_get_irq() already prints an error > > > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5846 > > Acked-by: Sudeep Holla <sudeep.holla@arm.com> > Sorry for this, I didn't mean to ack this patch, no idea how on earth I managed to do that (must be some wrong key combination in my email client) but I wanted and meant to ack only this [1]. Sorry for the noise. -- Regards, Sudeep [1] https://lore.kernel.org/r/20230712062853.11007-9-frank.li@vivo.com
© 2016 - 2024 Red Hat, Inc.