media: v4l2: Fix documentation for 12-bit packed Bayer

[PATCH] media: v4l2: Fix documentation for 12-bit packed Bayer

Posted by Suhrid Subramaniam 2 years, 7 months ago

Fix documentation for R13 and R33 low bits.

Signed-off-by: Suhrid Subramaniam <suhrid.subramaniam@mediatek.com>
---
 Documentation/userspace-api/media/v4l/pixfmt-srggb12p.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/userspace-api/media/v4l/pixfmt-srggb12p.rst b/Documentation/userspace-api/media/v4l/pixfmt-srggb12p.rst
index b6e79e2f8ce4..7c3810ff783c 100644
--- a/Documentation/userspace-api/media/v4l/pixfmt-srggb12p.rst
+++ b/Documentation/userspace-api/media/v4l/pixfmt-srggb12p.rst
@@ -60,7 +60,7 @@ Each cell is one byte.
           G\ :sub:`10low`\ (bits 3--0)
        -  G\ :sub:`12high`
        -  R\ :sub:`13high`
-       -  R\ :sub:`13low`\ (bits 3--2)
+       -  R\ :sub:`13low`\ (bits 7--4)
 
           G\ :sub:`12low`\ (bits 3--0)
     -  -  start + 12:
@@ -82,6 +82,6 @@ Each cell is one byte.
           G\ :sub:`30low`\ (bits 3--0)
        -  G\ :sub:`32high`
        -  R\ :sub:`33high`
-       -  R\ :sub:`33low`\ (bits 3--2)
+       -  R\ :sub:`33low`\ (bits 7--4)
 
           G\ :sub:`32low`\ (bits 3--0)
-- 
2.41.0

Re: [PATCH] media: v4l2: Fix documentation for 12-bit packed Bayer

Posted by Sakari Ailus 2 years, 5 months ago

Hi Suhrid,

On Mon, Jul 10, 2023 at 06:31:40PM -0700, Suhrid Subramaniam wrote:
> Fix documentation for R13 and R33 low bits.
> 
> Signed-off-by: Suhrid Subramaniam <suhrid.subramaniam@mediatek.com>

This doesn't match with the From: field.

I can fix it this time --- which one should it be? And please do fix this
going forward.

-- 
Sakari Ailus

Re: [PATCH] media: v4l2: Fix documentation for 12-bit packed Bayer

Posted by Suhrid Subramaniam 2 years, 5 months ago

Hi Sakari,

I didn't know that the "From" field needs to match the "signed-off-by" field.
If both need to match, please help me update both to
suhrid.subramaniam@mediatek.com
Thanks!

On Mon, Aug 14, 2023 at 3:06 PM Sakari Ailus <sakari.ailus@iki.fi> wrote:
>
> Hi Suhrid,
>
> On Mon, Jul 10, 2023 at 06:31:40PM -0700, Suhrid Subramaniam wrote:
> > Fix documentation for R13 and R33 low bits.
> >
> > Signed-off-by: Suhrid Subramaniam <suhrid.subramaniam@mediatek.com>
>
> This doesn't match with the From: field.
>
> I can fix it this time --- which one should it be? And please do fix this
> going forward.
>
> --
> Sakari Ailus