[v2] soc: ti: k3-ringacc: remove non-fatal probe deferral log

[RESEND PATCH v2] soc: ti: k3-ringacc: remove non-fatal probe deferral log

Posted by Jayesh Choudhary 2 years, 7 months ago

Drop the non-fatal probe deferral log for getting MSI domain.
This makes the kernel log clean and we do not get recurring logs
stating: "Failed to get MSI domain".

Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
---

v2 patch: <https://lore.kernel.org/all/20230117052052.29953-1-j-choudhary@ti.com/>

Changelog v1->v2:
- Removed the print instead of dropping the loglevel according to the comment
  on similar patch for udma:
  <https://lore.kernel.org/all/Y6wiXlZh1MUL2WrF@matsya/>
  
v1 patch: <https://lore.kernel.org/all/20221128102138.529398-1-j-choudhary@ti.com/>

 drivers/soc/ti/k3-ringacc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/soc/ti/k3-ringacc.c b/drivers/soc/ti/k3-ringacc.c
index 8f131368a758..5eb81895f8bc 100644
--- a/drivers/soc/ti/k3-ringacc.c
+++ b/drivers/soc/ti/k3-ringacc.c
@@ -1374,7 +1374,6 @@ static int k3_ringacc_init(struct platform_device *pdev,
 	dev->msi.domain = of_msi_get_domain(dev, dev->of_node,
 					    DOMAIN_BUS_TI_SCI_INTA_MSI);
 	if (!dev->msi.domain) {
-		dev_err(dev, "Failed to get MSI domain\n");
 		return -EPROBE_DEFER;
 	}
 
-- 
2.25.1

Re: [RESEND PATCH v2] soc: ti: k3-ringacc: remove non-fatal probe deferral log

Posted by Nishanth Menon 2 years, 6 months ago

On 16:12-20230710, Jayesh Choudhary wrote:
> Drop the non-fatal probe deferral log for getting MSI domain.
> This makes the kernel log clean and we do not get recurring logs
> stating: "Failed to get MSI domain".
> 
> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
> ---
> 
> v2 patch: <https://lore.kernel.org/all/20230117052052.29953-1-j-choudhary@ti.com/>
> 
> Changelog v1->v2:
> - Removed the print instead of dropping the loglevel according to the comment
>   on similar patch for udma:
>   <https://lore.kernel.org/all/Y6wiXlZh1MUL2WrF@matsya/>
>   
> v1 patch: <https://lore.kernel.org/all/20221128102138.529398-1-j-choudhary@ti.com/>
> 
>  drivers/soc/ti/k3-ringacc.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/soc/ti/k3-ringacc.c b/drivers/soc/ti/k3-ringacc.c
> index 8f131368a758..5eb81895f8bc 100644
> --- a/drivers/soc/ti/k3-ringacc.c
> +++ b/drivers/soc/ti/k3-ringacc.c
> @@ -1374,7 +1374,6 @@ static int k3_ringacc_init(struct platform_device *pdev,
>  	dev->msi.domain = of_msi_get_domain(dev, dev->of_node,
>  					    DOMAIN_BUS_TI_SCI_INTA_MSI);
>  	if (!dev->msi.domain) {
> -		dev_err(dev, "Failed to get MSI domain\n");
>  		return -EPROBE_DEFER;
>  	}

Do you need braces for a one liner? why not drop them?
>  
> -- 
> 2.25.1
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D