Galaxy S2 (i9100) panel updates v2

[PATCH v2 0/3] Galaxy S2 (i9100) panel updates v2

Posted by Paul Cercueil 2 years, 5 months ago

Hi,

Follow-up on my patchset that fixes the display of the Samsung Galaxy S2
when running PostmarketOS.

The first two patches update the LD9040 panel driver so that it looks
much better, and supports setting the backlight.

The third patch fixes the size of the panel in the Device Tree. The
previous values were completely bogus and caused Phosh (PmOS' UI) to
display tiny icons and text as it thought the DPI was much lower.

Changes since V1:
[1/3]: Remove spurious new line
[2/3]: Remove .get_brightness() callback, use bl_get_data() and
       backlight_get_brightness()

Cheers,
-Paul

Paul Cercueil (3):
  drm/panel: ld9040: Use better magic values
  drm/panel: ld9040: Register a backlight device
  ARM: dts: exynos/i9100: Fix LCD screen's physical size

 arch/arm/boot/dts/exynos4210-i9100.dts       |  4 +-
 drivers/gpu/drm/panel/panel-samsung-ld9040.c | 42 +++++++++++++++++---
 2 files changed, 38 insertions(+), 8 deletions(-)

-- 
2.40.1

Re: [PATCH v2 0/3] Galaxy S2 (i9100) panel updates v2

Posted by Sam Ravnborg 2 years, 5 months ago

Hi Paul.

On Sat, Jul 08, 2023 at 10:40:24AM +0200, Paul Cercueil wrote:
> Hi,
> 
> Follow-up on my patchset that fixes the display of the Samsung Galaxy S2
> when running PostmarketOS.
> 
> The first two patches update the LD9040 panel driver so that it looks
> much better, and supports setting the backlight.
> 
> The third patch fixes the size of the panel in the Device Tree. The
> previous values were completely bogus and caused Phosh (PmOS' UI) to
> display tiny icons and text as it thought the DPI was much lower.
> 
> Changes since V1:
> [1/3]: Remove spurious new line
> [2/3]: Remove .get_brightness() callback, use bl_get_data() and
>        backlight_get_brightness()
> 
> Cheers,
> -Paul
> 
> Paul Cercueil (3):
>   drm/panel: ld9040: Use better magic values
>   drm/panel: ld9040: Register a backlight device
>   ARM: dts: exynos/i9100: Fix LCD screen's physical size

The series looks good.

The first two patches are:
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>

The third patch are:
Acked-by: Sam Ravnborg <sam@ravnborg.org>

(I was not sure if I could/should stamp it r-b, so decided for the a-b).

	Sam

Re: [PATCH v2 0/3] Galaxy S2 (i9100) panel updates v2

Posted by Paul Cercueil 2 years, 5 months ago

Patches 1/3 and 2/3 applied to drm-misc-next.

I'll resend patch 3/3 as standalone.

Cheers,
-Paul

Le samedi 08 juillet 2023 à 10:40 +0200, Paul Cercueil a écrit :
> Hi,
> 
> Follow-up on my patchset that fixes the display of the Samsung Galaxy
> S2
> when running PostmarketOS.
> 
> The first two patches update the LD9040 panel driver so that it looks
> much better, and supports setting the backlight.
> 
> The third patch fixes the size of the panel in the Device Tree. The
> previous values were completely bogus and caused Phosh (PmOS' UI) to
> display tiny icons and text as it thought the DPI was much lower.
> 
> Changes since V1:
> [1/3]: Remove spurious new line
> [2/3]: Remove .get_brightness() callback, use bl_get_data() and
>        backlight_get_brightness()
> 
> Cheers,
> -Paul
> 
> Paul Cercueil (3):
>   drm/panel: ld9040: Use better magic values
>   drm/panel: ld9040: Register a backlight device
>   ARM: dts: exynos/i9100: Fix LCD screen's physical size
> 
>  arch/arm/boot/dts/exynos4210-i9100.dts       |  4 +-
>  drivers/gpu/drm/panel/panel-samsung-ld9040.c | 42 +++++++++++++++++-
> --
>  2 files changed, 38 insertions(+), 8 deletions(-)
>