[RFC PATCH 6/6] mm: Deprecate pasid field

Tina Zhang posted 6 patches 2 years, 7 months ago
[RFC PATCH 6/6] mm: Deprecate pasid field
Posted by Tina Zhang 2 years, 7 months ago
Drop the pasid field, as all the information needed for sva domain
management has been moved to the newly added iommu_mm field.

Signed-off-by: Tina Zhang <tina.zhang@intel.com>
---
 mm/init-mm.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/mm/init-mm.c b/mm/init-mm.c
index c43b7d0347312..50824dd5a949a 100644
--- a/mm/init-mm.c
+++ b/mm/init-mm.c
@@ -43,7 +43,6 @@ struct mm_struct init_mm = {
 	.user_ns	= &init_user_ns,
 	.cpu_bitmap	= CPU_BITS_NONE,
 #ifdef CONFIG_IOMMU_SVA
-	.pasid		= IOMMU_PASID_INVALID,
 	.iommu_mm       = &default_iommu_mm,
 #endif
 	INIT_MM_CONTEXT(init_mm)
-- 
2.34.1
Re: [RFC PATCH 6/6] mm: Deprecate pasid field
Posted by Jason Gunthorpe 2 years, 7 months ago
On Fri, Jul 07, 2023 at 09:34:41AM +0800, Tina Zhang wrote:
> Drop the pasid field, as all the information needed for sva domain
> management has been moved to the newly added iommu_mm field.
> 
> Signed-off-by: Tina Zhang <tina.zhang@intel.com>
> ---
>  mm/init-mm.c | 1 -
>  1 file changed, 1 deletion(-)

Shouldn't this remove the field from the mmu_struct as well??

Jason
RE: [RFC PATCH 6/6] mm: Deprecate pasid field
Posted by Zhang, Tina 2 years, 7 months ago

> -----Original Message-----
> From: Jason Gunthorpe <jgg@ziepe.ca>
> Sent: Tuesday, July 11, 2023 1:29 AM
> To: Zhang, Tina <tina.zhang@intel.com>
> Cc: Tian, Kevin <kevin.tian@intel.com>; Joerg Roedel <joro@8bytes.org>; Will
> Deacon <will@kernel.org>; Lu Baolu <baolu.lu@linux.intel.com>; Michael
> Shavit <mshavit@google.com>; iommu@lists.linux.dev; linux-
> kernel@vger.kernel.org
> Subject: Re: [RFC PATCH 6/6] mm: Deprecate pasid field
> 
> On Fri, Jul 07, 2023 at 09:34:41AM +0800, Tina Zhang wrote:
> > Drop the pasid field, as all the information needed for sva domain
> > management has been moved to the newly added iommu_mm field.
> >
> > Signed-off-by: Tina Zhang <tina.zhang@intel.com>
> > ---
> >  mm/init-mm.c | 1 -
> >  1 file changed, 1 deletion(-)
> 
> Shouldn't this remove the field from the mmu_struct as well??
Oops! You're right 😊

Thanks,
-Tina
> 
> Jason