drivers: bus: arm: Fix resource leaks in for_each_available_child_of_node loop

[PATCH] drivers: bus: arm: Fix resource leaks in for_each_available_child_of_node loop

Lu Hongfei posted 1 patch 2 years, 7 months ago

Download mbox

drivers/bus/arm-cci.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

Expand all Fold all

[PATCH] drivers: bus: arm: Fix resource leaks in for_each_available_child_of_node loop

Posted by Lu Hongfei 2 years, 7 months ago

Ensure child node references are decremented properly in
the error path.

Signed-off-by: Lu Hongfei <luhongfei@vivo.com>
---
 drivers/bus/arm-cci.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c
index b8184a903583..1f84a5528073 100644
--- a/drivers/bus/arm-cci.c
+++ b/drivers/bus/arm-cci.c
@@ -461,8 +461,10 @@ static int cci_probe_ports(struct device_node *np)
 
 		i = nb_ace + nb_ace_lite;
 
-		if (i >= nb_cci_ports)
+		if (i >= nb_cci_ports) {
+			of_node_put(cp);
 			break;
+		}
 
 		if (of_property_read_string(cp, "interface-type",
 					&match_str)) {
-- 
2.39.0