[PATCH v1] infiniband: irdma: Remove a duplicate assignment in irdma_query_ah()

Minjie Du posted 1 patch 2 years, 7 months ago
drivers/infiniband/hw/irdma/verbs.c | 1 -
1 file changed, 1 deletion(-)
[PATCH v1] infiniband: irdma: Remove a duplicate assignment in irdma_query_ah()
Posted by Minjie Du 2 years, 7 months ago
Delete a duplicate statement from this function implementation.

Signed-off-by: Minjie Du <duminjie@vivo.com>
---
 drivers/infiniband/hw/irdma/verbs.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/infiniband/hw/irdma/verbs.c b/drivers/infiniband/hw/irdma/verbs.c
index 9c4fe4fa9..a8326a95d 100644
--- a/drivers/infiniband/hw/irdma/verbs.c
+++ b/drivers/infiniband/hw/irdma/verbs.c
@@ -4424,7 +4424,6 @@ static int irdma_query_ah(struct ib_ah *ibah, struct rdma_ah_attr *ah_attr)
 		ah_attr->grh.traffic_class = ah->sc_ah.ah_info.tc_tos;
 		ah_attr->grh.hop_limit = ah->sc_ah.ah_info.hop_ttl;
 		ah_attr->grh.sgid_index = ah->sgid_index;
-		ah_attr->grh.sgid_index = ah->sgid_index;
 		memcpy(&ah_attr->grh.dgid, &ah->dgid,
 		       sizeof(ah_attr->grh.dgid));
 	}
-- 
2.39.0
Re: [PATCH v1] infiniband: irdma: Remove a duplicate assignment in irdma_query_ah()
Posted by Zhu Yanjun 2 years, 7 months ago
在 2023/7/6 10:27, Minjie Du 写道:
> Delete a duplicate statement from this function implementation.
> 

Please add "Fixes ".

Zhu Yanjun

> Signed-off-by: Minjie Du <duminjie@vivo.com>
> ---
>   drivers/infiniband/hw/irdma/verbs.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/irdma/verbs.c b/drivers/infiniband/hw/irdma/verbs.c
> index 9c4fe4fa9..a8326a95d 100644
> --- a/drivers/infiniband/hw/irdma/verbs.c
> +++ b/drivers/infiniband/hw/irdma/verbs.c
> @@ -4424,7 +4424,6 @@ static int irdma_query_ah(struct ib_ah *ibah, struct rdma_ah_attr *ah_attr)
>   		ah_attr->grh.traffic_class = ah->sc_ah.ah_info.tc_tos;
>   		ah_attr->grh.hop_limit = ah->sc_ah.ah_info.hop_ttl;
>   		ah_attr->grh.sgid_index = ah->sgid_index;
> -		ah_attr->grh.sgid_index = ah->sgid_index;
>   		memcpy(&ah_attr->grh.dgid, &ah->dgid,
>   		       sizeof(ah_attr->grh.dgid));
>   	}

Re: [PATCH v1] infiniband: irdma: Remove a duplicate assignment in irdma_query_ah()
Posted by Leon Romanovsky 2 years, 7 months ago
On Thu, 06 Jul 2023 10:27:03 +0800, Minjie Du wrote:
> Delete a duplicate statement from this function implementation.
> 
> 

Applied, thanks!

[1/1] infiniband: irdma: Remove a duplicate assignment in irdma_query_ah()
      https://git.kernel.org/rdma/rdma/c/34c2ce4c6e3cd2

Best regards,
-- 
Leon Romanovsky <leon@kernel.org>