qed: Remove a duplicate assignment in qed_rdma_create_srq()

[PATCH v2] qed: Remove a duplicate assignment in qed_rdma_create_srq()

Posted by Minjie Du 2 years, 7 months ago

Delete a duplicate statement from this function implementation.

Signed-off-by: Minjie Du <duminjie@vivo.com>
---
 drivers/net/ethernet/qlogic/qed/qed_rdma.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/qlogic/qed/qed_rdma.c b/drivers/net/ethernet/qlogic/qed/qed_rdma.c
index 5a5dbbb8d..41efced49 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_rdma.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_rdma.c
@@ -1795,7 +1795,6 @@ qed_rdma_create_srq(void *rdma_cxt,
 
 	opaque_fid = p_hwfn->hw_info.opaque_fid;
 
-	opaque_fid = p_hwfn->hw_info.opaque_fid;
 	init_data.opaque_fid = opaque_fid;
 	init_data.comp_mode = QED_SPQ_MODE_EBLOCK;
 
-- 
2.39.0

Re: [PATCH v2] qed: Remove a duplicate assignment in qed_rdma_create_srq()

Posted by Leon Romanovsky 2 years, 7 months ago

On Wed, Jul 05, 2023 at 06:35:46PM +0800, Minjie Du wrote:
> Delete a duplicate statement from this function implementation.
> 
> Signed-off-by: Minjie Du <duminjie@vivo.com>
> ---
>  drivers/net/ethernet/qlogic/qed/qed_rdma.c | 1 -
>  1 file changed, 1 deletion(-)

This patch should be resubmitted after merge window ends.

Please specify net-next target in patch subject and add changelog
that describes the differences between versions.

Thanks

> 
> diff --git a/drivers/net/ethernet/qlogic/qed/qed_rdma.c b/drivers/net/ethernet/qlogic/qed/qed_rdma.c
> index 5a5dbbb8d..41efced49 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_rdma.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_rdma.c
> @@ -1795,7 +1795,6 @@ qed_rdma_create_srq(void *rdma_cxt,
>  
>  	opaque_fid = p_hwfn->hw_info.opaque_fid;
>  
> -	opaque_fid = p_hwfn->hw_info.opaque_fid;
>  	init_data.opaque_fid = opaque_fid;
>  	init_data.comp_mode = QED_SPQ_MODE_EBLOCK;
>  
> -- 
> 2.39.0
> 
>