kernel: kprobes: Remove unnecessary ‘0’ values from ret

[PATCH] kernel: kprobes: Remove unnecessary ‘0’ values from ret

Posted by Li zeming 2 years, 7 months ago

ret is assigned first, so it does not need to initialize the assignment.

Signed-off-by: Li zeming <zeming@nfschina.com>
---
 kernel/kprobes.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/kprobes.c b/kernel/kprobes.c
index ec50f9f380c1..a009c8ccd8ea 100644
--- a/kernel/kprobes.c
+++ b/kernel/kprobes.c
@@ -2692,7 +2692,7 @@ void kprobe_free_init_mem(void)
 
 static int __init init_kprobes(void)
 {
-	int i, err = 0;
+	int i, err;
 
 	/* FIXME allocate the probe table, currently defined statically */
 	/* initialize all list heads */
-- 
2.18.2

Re: [PATCH] kernel: kprobes: Remove unnecessary ‘0’ values from ret

Posted by Masami Hiramatsu (Google) 2 years, 7 months ago

On Wed,  5 Jul 2023 04:10:56 +0800
Li zeming <zeming@nfschina.com> wrote:

> ret is assigned first, so it does not need to initialize the assignment.
> 

OK, but can you merge this to the first one?
https://lore.kernel.org/all/20230704192107.2944-1-zeming@nfschina.com/

Thank you,

> Signed-off-by: Li zeming <zeming@nfschina.com>
> ---
>  kernel/kprobes.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/kprobes.c b/kernel/kprobes.c
> index ec50f9f380c1..a009c8ccd8ea 100644
> --- a/kernel/kprobes.c
> +++ b/kernel/kprobes.c
> @@ -2692,7 +2692,7 @@ void kprobe_free_init_mem(void)
>  
>  static int __init init_kprobes(void)
>  {
> -	int i, err = 0;
> +	int i, err;
>  
>  	/* FIXME allocate the probe table, currently defined statically */
>  	/* initialize all list heads */
> -- 
> 2.18.2
> 


-- 
Masami Hiramatsu (Google) <mhiramat@kernel.org>