hwmon: bt1-pvt: Convert to devm_platform_ioremap_resource()

[PATCH] hwmon: bt1-pvt: Convert to devm_platform_ioremap_resource()

Posted by Yangtao Li 2 years, 7 months ago

Use devm_platform_ioremap_resource() to simplify code.

Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
 drivers/hwmon/bt1-pvt.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/drivers/hwmon/bt1-pvt.c b/drivers/hwmon/bt1-pvt.c
index 8d402a627306..b77ebac2e0ce 100644
--- a/drivers/hwmon/bt1-pvt.c
+++ b/drivers/hwmon/bt1-pvt.c
@@ -891,15 +891,8 @@ static struct pvt_hwmon *pvt_create_data(struct platform_device *pdev)
 static int pvt_request_regs(struct pvt_hwmon *pvt)
 {
 	struct platform_device *pdev = to_platform_device(pvt->dev);
-	struct resource *res;
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	if (!res) {
-		dev_err(pvt->dev, "Couldn't find PVT memresource\n");
-		return -EINVAL;
-	}
-
-	pvt->regs = devm_ioremap_resource(pvt->dev, res);
+	pvt->regs = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(pvt->regs))
 		return PTR_ERR(pvt->regs);
 
-- 
2.39.0

Re: [PATCH] hwmon: bt1-pvt: Convert to devm_platform_ioremap_resource()

Posted by Guenter Roeck 2 years, 6 months ago

On Tue, Jul 04, 2023 at 05:43:06PM +0800, Yangtao Li wrote:
> Use devm_platform_ioremap_resource() to simplify code.
> 
> Signed-off-by: Yangtao Li <frank.li@vivo.com>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/bt1-pvt.c | 9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)
> 
> diff --git a/drivers/hwmon/bt1-pvt.c b/drivers/hwmon/bt1-pvt.c
> index 8d402a627306..b77ebac2e0ce 100644
> --- a/drivers/hwmon/bt1-pvt.c
> +++ b/drivers/hwmon/bt1-pvt.c
> @@ -891,15 +891,8 @@ static struct pvt_hwmon *pvt_create_data(struct platform_device *pdev)
>  static int pvt_request_regs(struct pvt_hwmon *pvt)
>  {
>  	struct platform_device *pdev = to_platform_device(pvt->dev);
> -	struct resource *res;
>  
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	if (!res) {
> -		dev_err(pvt->dev, "Couldn't find PVT memresource\n");
> -		return -EINVAL;
> -	}
> -
> -	pvt->regs = devm_ioremap_resource(pvt->dev, res);
> +	pvt->regs = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(pvt->regs))
>  		return PTR_ERR(pvt->regs);
>