1. Patchew
  2. linux
  3. [RESEND v1 0/2] Add SPI module for StarFive JH7110 SoC
  4. View patch

[RESEND v1 1/2] dt-binding: spi: constrain minItems of clocks and clock-names

William Qiu posted 2 patches 2 years, 7 months ago
There is a newer version of this series
[RESEND v1 1/2] dt-binding: spi: constrain minItems of clocks and clock-names
Posted by William Qiu 2 years, 7 months ago 
The SPI controller only need apb_pclk clock to work properly on JH7110 SoC,
so there add minItems whose value is equal to 1. Other platforms do not
have this constraint.

Signed-off-by: William Qiu <william.qiu@starfivetech.com>
---
 Documentation/devicetree/bindings/spi/spi-pl022.yaml | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/spi/spi-pl022.yaml b/Documentation/devicetree/bindings/spi/spi-pl022.yaml
index 91e540a92faf..42bb34c39971 100644
--- a/Documentation/devicetree/bindings/spi/spi-pl022.yaml
+++ b/Documentation/devicetree/bindings/spi/spi-pl022.yaml
@@ -11,6 +11,7 @@ maintainers:

 allOf:
   - $ref: spi-controller.yaml#
+  - $ref: /schemas/arm/primecell.yaml#

 # We need a select here so we don't match all nodes with 'arm,primecell'
 select:
@@ -34,12 +35,16 @@ properties:
     maxItems: 1

   clocks:
+    minItems: 1
     maxItems: 2

   clock-names:
-    items:
-      - const: sspclk
-      - const: apb_pclk
+    oneOf:
+      - items:
+          - const: apb_pclk
+      - items:
+          - const: sspclk
+          - const: apb_pclk

   pl022,autosuspend-delay:
     description: delay in ms following transfer completion before the
--
2.34.1
Re: [RESEND v1 1/2] dt-binding: spi: constrain minItems of clocks and clock-names
Posted by Krzysztof Kozlowski 2 years, 7 months ago 
On 04/07/2023 11:21, William Qiu wrote:
> The SPI controller only need apb_pclk clock to work properly on JH7110 SoC,
> so there add minItems whose value is equal to 1. Other platforms do not
> have this constraint.
> 
> Signed-off-by: William Qiu <william.qiu@starfivetech.com>

I don't get why this is resent, but subject prefix is still wrong. It's
dt-bindings.

> ---
>  Documentation/devicetree/bindings/spi/spi-pl022.yaml | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/spi/spi-pl022.yaml b/Documentation/devicetree/bindings/spi/spi-pl022.yaml
> index 91e540a92faf..42bb34c39971 100644
> --- a/Documentation/devicetree/bindings/spi/spi-pl022.yaml
> +++ b/Documentation/devicetree/bindings/spi/spi-pl022.yaml
> @@ -11,6 +11,7 @@ maintainers:
> 
>  allOf:
>    - $ref: spi-controller.yaml#
> +  - $ref: /schemas/arm/primecell.yaml#

This looks unrelated, so keep it as separate commit with its own rationale.

> 
>  # We need a select here so we don't match all nodes with 'arm,primecell'
>  select:
> @@ -34,12 +35,16 @@ properties:
>      maxItems: 1
> 
>    clocks:
> +    minItems: 1
>      maxItems: 2
> 
>    clock-names:
> -    items:
> -      - const: sspclk
> -      - const: apb_pclk
> +    oneOf:
> +      - items:
> +          - const: apb_pclk
> +      - items:
> +          - const: sspclk
> +          - const: apb_pclk

Are you sure that your clock is APB pclk in such case?

Best regards,
Krzysztof
Re: [RESEND v1 1/2] dt-binding: spi: constrain minItems of clocks and clock-names
Posted by William Qiu 2 years, 7 months ago 

On 2023/7/4 17:38, Krzysztof Kozlowski wrote:
> On 04/07/2023 11:21, William Qiu wrote:
>> The SPI controller only need apb_pclk clock to work properly on JH7110 SoC,
>> so there add minItems whose value is equal to 1. Other platforms do not
>> have this constraint.
>> 
>> Signed-off-by: William Qiu <william.qiu@starfivetech.com>
> 
> I don't get why this is resent, but subject prefix is still wrong. It's
> dt-bindings.
> 
Will update.
>> ---
>>  Documentation/devicetree/bindings/spi/spi-pl022.yaml | 11 ++++++++---
>>  1 file changed, 8 insertions(+), 3 deletions(-)
>> 
>> diff --git a/Documentation/devicetree/bindings/spi/spi-pl022.yaml b/Documentation/devicetree/bindings/spi/spi-pl022.yaml
>> index 91e540a92faf..42bb34c39971 100644
>> --- a/Documentation/devicetree/bindings/spi/spi-pl022.yaml
>> +++ b/Documentation/devicetree/bindings/spi/spi-pl022.yaml
>> @@ -11,6 +11,7 @@ maintainers:
>> 
>>  allOf:
>>    - $ref: spi-controller.yaml#
>> +  - $ref: /schemas/arm/primecell.yaml#
> 
> This looks unrelated, so keep it as separate commit with its own rationale.
> 
Because "arm,primecell-periphid"  is need in JH7110 SoC, so I added them in
one commit, so do I need to put them in two commit?
>> 
>>  # We need a select here so we don't match all nodes with 'arm,primecell'
>>  select:
>> @@ -34,12 +35,16 @@ properties:
>>      maxItems: 1
>> 
>>    clocks:
>> +    minItems: 1
>>      maxItems: 2
>> 
>>    clock-names:
>> -    items:
>> -      - const: sspclk
>> -      - const: apb_pclk
>> +    oneOf:
>> +      - items:
>> +          - const: apb_pclk
>> +      - items:
>> +          - const: sspclk
>> +          - const: apb_pclk
> 
> Are you sure that your clock is APB pclk in such case?
> 
Yes, in JH7110 SoC is APB pclk in such case.

Thanks for taking time to review this patch series.
> Best regards,
> Krzysztof
>
Re: [RESEND v1 1/2] dt-binding: spi: constrain minItems of clocks and clock-names
Posted by Krzysztof Kozlowski 2 years, 7 months ago 
On 05/07/2023 05:37, William Qiu wrote:
>>> ---
>>>  Documentation/devicetree/bindings/spi/spi-pl022.yaml | 11 ++++++++---
>>>  1 file changed, 8 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/spi/spi-pl022.yaml b/Documentation/devicetree/bindings/spi/spi-pl022.yaml
>>> index 91e540a92faf..42bb34c39971 100644
>>> --- a/Documentation/devicetree/bindings/spi/spi-pl022.yaml
>>> +++ b/Documentation/devicetree/bindings/spi/spi-pl022.yaml
>>> @@ -11,6 +11,7 @@ maintainers:
>>>
>>>  allOf:
>>>    - $ref: spi-controller.yaml#
>>> +  - $ref: /schemas/arm/primecell.yaml#
>>
>> This looks unrelated, so keep it as separate commit with its own rationale.
>>
> Because "arm,primecell-periphid"  is need in JH7110 SoC, so I added them in
> one commit, so do I need to put them in two commit?

You need to provide rationale why this is needed. I would assume this is
needed for every primecell, not only JH7110, right?



Best regards,
Krzysztof
Re: [RESEND v1 1/2] dt-binding: spi: constrain minItems of clocks and clock-names
Posted by William Qiu 2 years, 7 months ago 

On 2023/7/5 14:00, Krzysztof Kozlowski wrote:
> On 05/07/2023 05:37, William Qiu wrote:
>>>> ---
>>>>  Documentation/devicetree/bindings/spi/spi-pl022.yaml | 11 ++++++++---
>>>>  1 file changed, 8 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/spi/spi-pl022.yaml b/Documentation/devicetree/bindings/spi/spi-pl022.yaml
>>>> index 91e540a92faf..42bb34c39971 100644
>>>> --- a/Documentation/devicetree/bindings/spi/spi-pl022.yaml
>>>> +++ b/Documentation/devicetree/bindings/spi/spi-pl022.yaml
>>>> @@ -11,6 +11,7 @@ maintainers:
>>>>
>>>>  allOf:
>>>>    - $ref: spi-controller.yaml#
>>>> +  - $ref: /schemas/arm/primecell.yaml#
>>>
>>> This looks unrelated, so keep it as separate commit with its own rationale.
>>>
>> Because "arm,primecell-periphid"  is need in JH7110 SoC, so I added them in
>> one commit, so do I need to put them in two commit?
> 
> You need to provide rationale why this is needed. I would assume this is
> needed for every primecell, not only JH7110, right?
> 
> 
All right, I'll keep it as separate commit.
> 
> Best regards,
> Krzysztof
>

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.