ALSA: hda/realtek: add extra ROOG laptop quirks

[PATCH v2 0/5] ALSA: hda/realtek: add extra ROOG laptop quirks

Posted by Luke D. Jones 2 years, 7 months ago

- Adds quirks for various ASUS ROG laptops.
- Fixes up a previous quirk
- Fixes up a whitespace error

This introduces a quirk chain that is similar to the ROG Ally quirk chain, but
due to the verb configs being currently tested these new quirks do not use it
and instead add a new chain. It is likely the Ally quirk will be removed in
favour of this new chain in future.

Luke D. Jones (5):
  ALSA: hda/realtek: Add quirk for ASUS ROG GX650P
  ALSA: hda/realtek: Add quirk for ASUS ROG GA402X
  ALSA: hda/realtek: Amend G634 quirk to enable rear speakers
  ALSA: hda/realtek: Add quirk for ASUS ROG G614Jx
  Fixes: 31278997add6 (ALSA: hda/realtek - Add headset quirk for Dell
    DT)

 sound/pci/hda/patch_realtek.c | 35 +++++++++++++++++++++++++++++++++--
 1 file changed, 33 insertions(+), 2 deletions(-)

-- 
2.41.0

Re: [PATCH v2 0/5] ALSA: hda/realtek: add extra ROOG laptop quirks

Posted by Takashi Iwai 2 years, 7 months ago

On Tue, 04 Jul 2023 06:46:14 +0200,
Luke D. Jones wrote:
> 
> - Adds quirks for various ASUS ROG laptops.
> - Fixes up a previous quirk
> - Fixes up a whitespace error
> 
> This introduces a quirk chain that is similar to the ROG Ally quirk chain, but
> due to the verb configs being currently tested these new quirks do not use it
> and instead add a new chain. It is likely the Ally quirk will be removed in
> favour of this new chain in future.
> 
> Luke D. Jones (5):
>   ALSA: hda/realtek: Add quirk for ASUS ROG GX650P
>   ALSA: hda/realtek: Add quirk for ASUS ROG GA402X
>   ALSA: hda/realtek: Amend G634 quirk to enable rear speakers
>   ALSA: hda/realtek: Add quirk for ASUS ROG G614Jx
>   Fixes: 31278997add6 (ALSA: hda/realtek - Add headset quirk for Dell
>     DT)

Now applied all patches.  The subject line of the last patch was
modified to match with the standard.  The Fixes tag was moved to the
right place, too.


thanks,

Takashi

Re: [PATCH v2 0/5] ALSA: hda/realtek: add extra ROOG laptop quirks

Posted by Luke Jones 2 years, 7 months ago

On Tue, 2023-07-04 at 08:44 +0200, Takashi Iwai wrote:
> On Tue, 04 Jul 2023 06:46:14 +0200,
> Luke D. Jones wrote:
> > 
> > - Adds quirks for various ASUS ROG laptops.
> > - Fixes up a previous quirk
> > - Fixes up a whitespace error
> > 
> > This introduces a quirk chain that is similar to the ROG Ally quirk
> > chain, but
> > due to the verb configs being currently tested these new quirks do
> > not use it
> > and instead add a new chain. It is likely the Ally quirk will be
> > removed in
> > favour of this new chain in future.
> > 
> > Luke D. Jones (5):
> >   ALSA: hda/realtek: Add quirk for ASUS ROG GX650P
> >   ALSA: hda/realtek: Add quirk for ASUS ROG GA402X
> >   ALSA: hda/realtek: Amend G634 quirk to enable rear speakers
> >   ALSA: hda/realtek: Add quirk for ASUS ROG G614Jx
> >   Fixes: 31278997add6 (ALSA: hda/realtek - Add headset quirk for
> > Dell
> >     DT)
> 
> Now applied all patches.  The subject line of the last patch was
> modified to match with the standard.  The Fixes tag was moved to the
> right place, too.

Thanks mate. I looked at the patch guidelines for that but I must have
misunderstood it :)